From b2724c7438432c2b2d513fb59d3f669567958b97 Mon Sep 17 00:00:00 2001 From: Daniel F Date: Tue, 11 Jul 2023 22:14:00 +0100 Subject: [PATCH] Updated AgedBrieItemUpdateService tests, SulfurasItemUpdateService --- .../aged_brie_item_update_service_test.go | 4 +- go/services/sulfuras_item_update_service.go | 48 +------------------ 2 files changed, 3 insertions(+), 49 deletions(-) diff --git a/go/services/aged_brie_item_update_service_test.go b/go/services/aged_brie_item_update_service_test.go index 62dc589b..a22812df 100644 --- a/go/services/aged_brie_item_update_service_test.go +++ b/go/services/aged_brie_item_update_service_test.go @@ -54,10 +54,10 @@ func TestAgedBrieItemUpdateService_QualityNotHigherThan50(t *testing.T) { // sellIn date must decrease func TestAgedBrieItemUpdateService_SellInIsDecreased(t *testing.T) { runTestCase(t, func( - sulfurasItemUpdateService SulfurasItemUpdateService, + agedBrieItemUpdateService AgedBrieItemUpdateService, ) { item := models.NewItem(&models.ItemModel{"Aged Brie", 5, 5}) - sulfurasItemUpdateService.UpdateQuality(item) + agedBrieItemUpdateService.UpdateQuality(item) assert.Equal(t, 4, item.Model.SellIn) }) } diff --git a/go/services/sulfuras_item_update_service.go b/go/services/sulfuras_item_update_service.go index 9342f826..44ccaf27 100644 --- a/go/services/sulfuras_item_update_service.go +++ b/go/services/sulfuras_item_update_service.go @@ -19,53 +19,7 @@ func (this SulfurasItemUpdateService) UpdateQuality(item *models.Item) error { item.Mutex.Lock() defer item.Mutex.Unlock() - itemModel := item.Model - - if itemModel.Name != "Aged Brie" && itemModel.Name != "Backstage passes to a TAFKAL80ETC concert" { - if itemModel.Quality > 0 { - if itemModel.Name != "Sulfuras, Hand of Ragnaros" { - itemModel.Quality = itemModel.Quality - 1 - } - } - } else { - if itemModel.Quality < 50 { - itemModel.Quality = itemModel.Quality + 1 - if itemModel.Name == "Backstage passes to a TAFKAL80ETC concert" { - if itemModel.SellIn < 11 { - if itemModel.Quality < 50 { - itemModel.Quality = itemModel.Quality + 1 - } - } - if itemModel.SellIn < 6 { - if itemModel.Quality < 50 { - itemModel.Quality = itemModel.Quality + 1 - } - } - } - } - } - - if itemModel.Name != "Sulfuras, Hand of Ragnaros" { - itemModel.SellIn = itemModel.SellIn - 1 - } - - if itemModel.SellIn < 0 { - if itemModel.Name != "Aged Brie" { - if itemModel.Name != "Backstage passes to a TAFKAL80ETC concert" { - if itemModel.Quality > 0 { - if itemModel.Name != "Sulfuras, Hand of Ragnaros" { - itemModel.Quality = itemModel.Quality - 1 - } - } - } else { - itemModel.Quality = itemModel.Quality - itemModel.Quality - } - } else { - if itemModel.Quality < 50 { - itemModel.Quality = itemModel.Quality + 1 - } - } - } + item.Model.Quality = 80 return nil }