OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2025-12-12 04:12:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Updated PHP version for PHP7.2+

Browse Source 
Removed PHP5 (no longer supported)
Renamed PHP7 to PHP - consistent with other kata
Added the same helpers as other PHP Kata
Updated the code to PHP7.2+ standard
Didn't change GildedRose updateQuality method
Updated GildedRoseTest (still failing)
Added ApprovalTest (passing)
- same text file as texttests / ThirtyDays / stdout.gr (only renamed).
This commit is contained in:
Pen-y-Fan 2020-07-23 22:49:59 +01:00
parent ed7a787e4f
commit b4a02d3f5e
1 changed files with 14 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
php5/src/gilded_rose.php → php/src/GildedRose.php
View File

@ -1,14 +1,23 @@
<?php <?php
class GildedRose { declare(strict_types=1);
namespace GildedRose;
final class GildedRose
{
/**
* @var Item[]
*/
private $items; private $items;
function __construct($items) { public function __construct(array $items)
{
$this->items = $items; $this->items = $items;
} }
function update_quality() { public function updateQuality(): void
{
foreach ($this->items as $item) { foreach ($this->items as $item) {
if ($item->name != 'Aged Brie' and $item->name != 'Backstage passes to a TAFKAL80ETC concert') { if ($item->name != 'Aged Brie' and $item->name != 'Backstage passes to a TAFKAL80ETC concert') {
if ($item->quality > 0) { if ($item->quality > 0) {
@ -33,11 +42,11 @@ class GildedRose {
} }
} }
} }
if ($item->name != 'Sulfuras, Hand of Ragnaros') { if ($item->name != 'Sulfuras, Hand of Ragnaros') {
$item->sell_in = $item->sell_in - 1; $item->sell_in = $item->sell_in - 1;
} }
if ($item->sell_in < 0) { if ($item->sell_in < 0) {
if ($item->name != 'Aged Brie') { if ($item->name != 'Aged Brie') {
if ($item->name != 'Backstage passes to a TAFKAL80ETC concert') { if ($item->name != 'Backstage passes to a TAFKAL80ETC concert') {
@ -58,22 +67,3 @@ class GildedRose {
} }
} }
} }
class Item {
public $name;
public $sell_in;
public $quality;
function __construct($name, $sell_in, $quality) {
$this->name = $name;
$this->sell_in = $sell_in;
$this->quality = $quality;
}
public function __toString() {
return "{$this->name}, {$this->sell_in}, {$this->quality}";
}
}