OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 06:21:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

DailyItemUpdate: seperate handling for different item types

Browse Source
This commit is contained in:
Sarah Ashri 2024-03-13 11:40:26 +10:00
parent 03032c91c2
commit b5f5867081
1 changed files with 17 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
csharpcore/GildedRose/GildedRose.cs
View File

@ -26,6 +26,10 @@ public class GildedRose
private static bool IsBackstagePassesItem(Item item) => item.Name.ToLower().Contains("backstage passes"); private static bool IsBackstagePassesItem(Item item) => item.Name.ToLower().Contains("backstage passes");
private static bool IsBetterWithAgeItem(Item item) => item.Name.ToLower().Equals("aged brie"); private static bool IsBetterWithAgeItem(Item item) => item.Name.ToLower().Equals("aged brie");
private static bool IsRegularItem(Item item) => (!IsLegendaryItem(item) &&
!IsBackstagePassesItem(item) &&
!IsBetterWithAgeItem(item));
@ -34,14 +38,15 @@ public class GildedRose
{ {
if (IsLegendaryItem(item)) return; if (IsLegendaryItem(item)) return;
if (!IsBetterWithAgeItem(item) && !IsBackstagePassesItem(item)) if (IsRegularItem(item))
{ {
if (item.Quality > MinQuality) if (item.Quality > MinQuality)
{ {
item.Quality = item.Quality - 1; item.Quality = item.Quality - 1;
} }
} }
else
if(IsBetterWithAgeItem(item) || IsBackstagePassesItem(item))
{ {
if (item.Quality < MaxQuality) if (item.Quality < MaxQuality)
{ {
@ -72,21 +77,20 @@ public class GildedRose
if (item.SellIn < 0) if (item.SellIn < 0)
{ {
if (!IsBetterWithAgeItem(item)) if (IsRegularItem(item))
{ {
if (!IsBackstagePassesItem(item)) if (item.Quality > MinQuality)
{ {
if (item.Quality > MinQuality) item.Quality = item.Quality - 1;
{
item.Quality = item.Quality - 1;
}
}
else
{
item.Quality = item.Quality - item.Quality;
} }
} }
else
if(IsBackstagePassesItem(item))
{
item.Quality = item.Quality - item.Quality;
}
if(IsBetterWithAgeItem(item))
{ {
if (item.Quality < MaxQuality) if (item.Quality < MaxQuality)
{ {