OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 14:31:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactored to class methods

Browse Source
This commit is contained in:
Paul Robinson 2019-03-25 11:59:23 +00:00
parent 329effa522
commit b94a1948de
1 changed files with 58 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

88
ruby/gilded_rose.rb
View File

@ -8,41 +8,15 @@ class GildedRose
@items.each do |item|
case item.name
when "Aged Brie"
item.sell_in = item.sell_in - 1
item.quality = item.quality + 1 unless item.quality >= 50
return
return AgedBrieItem.update_quality(item)
when "Backstage passes to a TAFKAL80ETC concert"
item.sell_in = item.sell_in - 1
if item.sell_in < 0
item.quality = 0
elsif item.sell_in < 5
item.quality = item.quality + 3
elsif item.sell_in < 10
item.quality = item.quality + 2
else
item.quality = item.quality + 1
end
return
return BackstagePassItem.update_quality(item)
when "Conjured item"
item.sell_in = item.sell_in - 1
if item.sell_in < 0
item.quality = item.quality - 4
else
item.quality = item.quality - 2
end
item.quality = 0 if item.quality < 0
return
return ConjuredItem.update_quality(item)
when "Sulfuras, Hand of Ragnaros"
return
else
item.sell_in = item.sell_in - 1
if item.sell_in < 0
item.quality = item.quality - 2
else
item.quality = item.quality - 1
end
item.quality = 0 if item.quality < 0
return
return NormalItem.update_quality(item)
end
end
end
@ -60,4 +34,58 @@ class Item
def to_s()
"#{@name}, #{@sell_in}, #{@quality}"
end
end
class MyItem
def self.update_sell_in(item)
item.sell_in = item.sell_in - 1
return item
end
end
class AgedBrieItem < MyItem
def self.update_quality(item)
item = update_sell_in(item)
item.quality = item.quality + 1 unless item.quality >= 50
return item
end
end
class BackstagePassItem < MyItem
def self.update_quality(item)
item = update_sell_in(item)
if item.sell_in < 0
item.quality = 0
elsif item.sell_in < 5
item.quality = item.quality + 3
elsif item.sell_in < 10
item.quality = item.quality + 2
else
item.quality = item.quality + 1
end
end
end
class ConjuredItem < MyItem
def self.update_quality(item)
item = update_sell_in(item)
if item.sell_in < 0
item.quality = item.quality - 4
else
item.quality = item.quality - 2
end
item.quality = 0 if item.quality < 0
end
end
class NormalItem < MyItem
def self.update_quality(item)
item = update_sell_in(item)
if item.sell_in < 0
item.quality = item.quality - 2
else
item.quality = item.quality - 1
end
item.quality = 0 if item.quality < 0
end
end