OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

basic refactoring done, added min and max variables, changed addition and subtraction of quality;

Browse Source
This commit is contained in:
Ben Hemann 2021-06-07 14:07:51 -05:00
parent 35db991828
commit ba05d9fb40
1 changed files with 19 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
TypeScript/app/gilded-rose.ts
View File

@ -20,27 +20,26 @@ export class GildedRose {
// Method for updating item quality // Method for updating item quality
updateQuality() { updateQuality() {
var maxQuality = 50;
var minQuality = 0;
for (let i = 0; i < this.items.length; i++) { for (let i = 0; i < this.items.length; i++) {
if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') { if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert'
if (this.items[i].quality > 0) { && this.items[i].name != 'Sulfuras, Hand of Ragnaros' && this.items[i].quality >minQuality) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') { this.items[i].quality -=1;
this.items[i].quality = this.items[i].quality - 1
}
}
} else { } else {
if (this.items[i].quality < 50) { if (this.items[i].quality < maxQuality) {
this.items[i].quality = this.items[i].quality + 1 this.items[i].quality += 1;
if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') { if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].sellIn < 11) { if (this.items[i].sellIn <= 10) {
// quality goes up by 2 when days are 10 or less // quality goes up by 2 when days are 10 or less
if (this.items[i].quality < 50) { if (this.items[i].quality < maxQuality) {
this.items[i].quality = this.items[i].quality + 1 this.items[i].quality += 1;
} }
} }
// quality goes up by 3 when days are 5 of less // quality goes up by 3 when days are 5 of less
if (this.items[i].sellIn < 6) { if (this.items[i].sellIn <= 5) {
if (this.items[i].quality < 50) { if (this.items[i].quality < maxQuality) {
this.items[i].quality = this.items[i].quality + 1 this.items[i].quality += 1;
} }
} }
} }
@ -48,26 +47,26 @@ export class GildedRose {
} }
// checking for legendary to subtract sell by date // checking for legendary to subtract sell by date
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') { if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].sellIn = this.items[i].sellIn - 1; this.items[i].sellIn -= 1;
} }
if (this.items[i].sellIn < 0) { if (this.items[i].sellIn < 0) {
if (this.items[i].name != 'Aged Brie') { if (this.items[i].name != 'Aged Brie') {
if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') { if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) { if (this.items[i].quality > minQuality) {
// move this if above line 57 if // move this if above line 57 if
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') { if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1 this.items[i].quality -= 1;
} }
} }
} else { } else {
this.items[i].quality = this.items[i].quality - this.items[i].quality this.items[i].quality -= this.items[i].quality;
} }
// aged brie increases in quality here // aged brie increases in quality here
} else { } else {
if (this.items[i].quality < 50) { if (this.items[i].quality < maxQuality) {
this.items[i].quality = this.items[i].quality + 1 this.items[i].quality += 1;
} }
} }
} }