OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-10 04:01:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add some comments to code that can't be changed because of requirements

Browse Source
This commit is contained in:
Arno Chauveau 2025-07-24 09:53:13 +02:00
parent 3872d78106
commit ba40febb07
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
TypeScript/app/gilded-rose.ts
View File

@ -3,6 +3,13 @@ export class Item {
sellIn: number; sellIn: number;
quality: number; quality: number;
// can't edit this constructor because of the kata rules.
// but I would change the constructor to take a javaScript object.
// It makes the consumer code more readable.
// e.g. new Item({ name: "standard item", sellIn: 0, quality: 2 })
// instead of new Item("standard item", 0, 2)
// I would also type the parameters, because now they are implicitly any.
constructor(name, sellIn, quality) { constructor(name, sellIn, quality) {
this.name = name; this.name = name;
this.sellIn = sellIn; this.sellIn = sellIn;
@ -11,6 +18,8 @@ export class Item {
} }
export class GildedRose { export class GildedRose {
// also can't edit this because of the kata rules.
// But I prefer typing this as : Item[]
items: Array<Item>; items: Array<Item>;
constructor(items = [] as Array<Item>) { constructor(items = [] as Array<Item>) {