OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-04 09:11:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lift-up conditional - isBackstagePasses

Browse Source
This commit is contained in:
villanibe 2025-06-26 15:40:32 +02:00
parent 8f75b49648
commit ba9330aab7
1 changed files with 38 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

94
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -26,29 +26,56 @@ class GildedRose {
private static void doUpdateQuality(Item item) { private static void doUpdateQuality(Item item) {
// processing quality // processing quality
boolean isAgedBrie = item.name.equals(AGED_BRIE); boolean isAgedBrie = item.name.equals(AGED_BRIE);
boolean isBackstagePasses = item.name.equals(BACKSTAGE_PASSES);
if (isAgedBrie) { if (isAgedBrie) {
// processing quality
if (item.quality < QUALITY_LEVEL_50) {
item.quality = item.quality + 1;
}
// processing sell date
item.sellIn = item.sellIn - 1;
// processing sell date
if (item.sellIn < SELL_IN_DAY0) {
if (item.quality < QUALITY_LEVEL_50) {
item.quality = item.quality + 1;
}
}
} else if (isBackstagePasses) {
// processing quality // processing quality
if (item.quality < QUALITY_LEVEL_50) { if (item.quality < QUALITY_LEVEL_50) {
item.quality = item.quality + 1; item.quality = item.quality + 1;
// processing sell date // processing sell date
if (item.name.equals(BACKSTAGE_PASSES)) { if (item.sellIn < SELL_IN_DAY11) {
if (item.quality < QUALITY_LEVEL_50) {
if (item.sellIn < SELL_IN_DAY11) { item.quality = item.quality + 1;
if (item.quality < QUALITY_LEVEL_50) {
item.quality = item.quality + 1;
}
} }
}
if (item.sellIn < SELL_IN_DAY6) { if (item.sellIn < SELL_IN_DAY6) {
if (item.quality < QUALITY_LEVEL_50) { if (item.quality < QUALITY_LEVEL_50) {
item.quality = item.quality + 1; item.quality = item.quality + 1;
}
} }
} }
} }
// processing sell date
item.sellIn = item.sellIn - 1;
// processing sell date
if (item.sellIn < SELL_IN_DAY0) {
item.quality = QUALITY_LEVEL_0;
}
} else {
if (item.quality > QUALITY_LEVEL_0) {
if (!item.name.equals(SULFURAS)) {
item.quality = item.quality - 1;
}
}
// processing sell date // processing sell date
if (!item.name.equals(SULFURAS)) { if (!item.name.equals(SULFURAS)) {
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;
@ -56,57 +83,12 @@ class GildedRose {
// processing sell date // processing sell date
if (item.sellIn < SELL_IN_DAY0) { if (item.sellIn < SELL_IN_DAY0) {
if (item.quality < QUALITY_LEVEL_50) { // processing quality
item.quality = item.quality + 1;
}
}
} else {
if (!item.name.equals(BACKSTAGE_PASSES)) {
if (item.quality > QUALITY_LEVEL_0) { if (item.quality > QUALITY_LEVEL_0) {
if (!item.name.equals(SULFURAS)) { if (!item.name.equals(SULFURAS)) {
item.quality = item.quality - 1; item.quality = item.quality - 1;
} }
} }
} else {
// processing quality
if (item.quality < QUALITY_LEVEL_50) {
item.quality = item.quality + 1;
// processing sell date
if (item.name.equals(BACKSTAGE_PASSES)) {
if (item.sellIn < SELL_IN_DAY11) {
if (item.quality < QUALITY_LEVEL_50) {
item.quality = item.quality + 1;
}
}
if (item.sellIn < SELL_IN_DAY6) {
if (item.quality < QUALITY_LEVEL_50) {
item.quality = item.quality + 1;
}
}
}
}
}
// processing sell date
if (!item.name.equals(SULFURAS)) {
item.sellIn = item.sellIn - 1;
}
// processing sell date
if (item.sellIn < SELL_IN_DAY0) {
if (!item.name.equals(BACKSTAGE_PASSES)) {
// processing quality
if (item.quality > QUALITY_LEVEL_0) {
if (!item.name.equals(SULFURAS)) {
item.quality = item.quality - 1;
}
}
} else {
item.quality = QUALITY_LEVEL_0;
}
} }
} }
} }