OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 14:31:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed test cases

Browse Source
This commit is contained in:
Yash Dubey 2023-11-29 22:37:26 +05:30
parent 05be0f3c05
commit bcf8139af4
3 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ruby/gilded_rose.rb
View File

@ -11,13 +11,14 @@ class GildedRose
# Decreasing the quality of item # Decreasing the quality of item
if !item.is_aged_brie? && !item.is_backstage_passes? && !item.is_sulfuras? && item.quality > 0 if !item.is_aged_brie? && !item.is_backstage_passes? && !item.is_sulfuras? && item.quality > 0
if item.sell_in < 0 if item.sell_in < 0
item.quality = item.quality - 4 if item.is_conjured_mana_cake? item.quality = item.quality - 4 if item.is_conjured_mana_cake? # Decreasing twice quality if item is conjured_mana_cake
item.quality = item.quality - 2 if !item.is_conjured_mana_cake? item.quality = item.quality - 2 if !item.is_conjured_mana_cake? # Decreasing 2 quality if item is not conjured_mana_cake
else else
item.quality = item.quality - 2 if item.is_conjured_mana_cake? item.quality = item.quality - 2 if item.is_conjured_mana_cake? # Decreasing twice quality if item is conjured_mana_cake
item.quality = item.quality - 1 if !item.is_conjured_mana_cake? item.quality = item.quality - 1 if !item.is_conjured_mana_cake? # Decreasing 2 quality if item is not conjured_mana_cake
end end
elsif item.quality < 50 && (item.is_backstage_passes? || item.is_aged_brie?) elsif item.quality < 50 && (item.is_backstage_passes? || item.is_aged_brie?)
# Increasing quality for backstage passes and aged brie item according based on sell in days
if item.sell_in < 11 if item.sell_in < 11
item.quality = item.quality + 2 item.quality = item.quality + 2
elsif item.sell_in < 6 elsif item.sell_in < 6
@ -25,16 +26,19 @@ class GildedRose
else else
item.quality = item.quality + 1 item.quality = item.quality + 1
end end
item.quality = 50 if item.quality > 50 item.quality = 50 if item.quality > 50 # Insuring item quality should not get over 50
item.quality = 0 if item.quality < 0 # Insuring item quality should not be negative
end end
if !item.is_sulfuras? if !item.is_sulfuras?
item.sell_in = item.sell_in - 1 item.sell_in = item.sell_in - 1 # Decreasing sell in daily if item is not sulfuras
end end
if item.sell_in < 0 if item.sell_in < 0
# Setting quality to 0 if concert is over
item.quality = item.quality - item.quality if item.is_aged_brie? || item.is_backstage_passes? item.quality = item.quality - item.quality if item.is_aged_brie? || item.is_backstage_passes?
end end
item.quality = 50 if item.quality > 50 && item.is_sulfuras?
end end
end end
end end

2
ruby/gilded_rose_spec.rb
View File

@ -7,7 +7,7 @@ describe GildedRose do
it "does not change the name" do it "does not change the name" do
items = [Item.new("foo", 0, 0)] items = [Item.new("foo", 0, 0)]
GildedRose.new(items).update_quality() GildedRose.new(items).update_quality()
expect(items[0].name).to eq "fixme" expect(items[0].name).to eq "foo"
end end
end end

2
ruby/gilded_rose_tests.rb
View File

@ -7,7 +7,7 @@ class TestUntitled < Test::Unit::TestCase
def test_foo def test_foo
items = [Item.new("foo", 0, 0)] items = [Item.new("foo", 0, 0)]
GildedRose.new(items).update_quality() GildedRose.new(items).update_quality()
assert_equal items[0].name, "fixme" assert_equal items[0].name, "foo"
end end
end end