mirror of
https://github.com/emilybache/GildedRose-Refactoring-Kata.git
synced 2026-02-11 04:31:21 +00:00
Refactor upgradeQuality
This commit is contained in:
parent
37969bfce3
commit
bdfb5f18e6
@ -13,17 +13,17 @@ class GildedRose(var items: List<Item>) {
|
|||||||
) {
|
) {
|
||||||
downGradeQuality(i)
|
downGradeQuality(i)
|
||||||
} else {
|
} else {
|
||||||
items[i].quality = upgradeQuality(items[i].quality)
|
upgradeQuality(i)
|
||||||
|
|
||||||
if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") {
|
if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") {
|
||||||
when {
|
when {
|
||||||
items[i].sellIn < 6 -> {
|
items[i].sellIn < 6 -> {
|
||||||
items[i].quality = upgradeQuality(items[i].quality)
|
upgradeQuality(i)
|
||||||
items[i].quality = upgradeQuality(items[i].quality)
|
upgradeQuality(i)
|
||||||
}
|
}
|
||||||
|
|
||||||
items[i].sellIn < 11 -> {
|
items[i].sellIn < 11 -> {
|
||||||
items[i].quality = upgradeQuality(items[i].quality)
|
upgradeQuality(i)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@ -34,7 +34,7 @@ class GildedRose(var items: List<Item>) {
|
|||||||
if (items[i].sellIn < 0) {
|
if (items[i].sellIn < 0) {
|
||||||
when (items[i].name) {
|
when (items[i].name) {
|
||||||
"Aged Brie" -> {
|
"Aged Brie" -> {
|
||||||
items[i].quality = upgradeQuality(items[i].quality)
|
upgradeQuality(i)
|
||||||
}
|
}
|
||||||
|
|
||||||
"Backstage passes to a TAFKAL80ETC concert" -> {
|
"Backstage passes to a TAFKAL80ETC concert" -> {
|
||||||
@ -63,9 +63,10 @@ class GildedRose(var items: List<Item>) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private fun upgradeQuality(quality: Int): Int {
|
private fun upgradeQuality(i: Int) {
|
||||||
if (quality < 50) return quality + 1
|
if (items[i].quality < 50) {
|
||||||
return quality
|
items[i].quality += 1
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user