mirror of
https://github.com/emilybache/GildedRose-Refactoring-Kata.git
synced 2026-02-15 06:21:29 +00:00
cleanup
This commit is contained in:
parent
f23572d512
commit
bef68f0068
@ -46,55 +46,6 @@ class GildedRose {
|
||||
},
|
||||
(a, b) -> b).getQuality();
|
||||
|
||||
/*
|
||||
if (!item.name.equals("Aged Brie")
|
||||
&& !item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
|
||||
if (item.quality > 0) {
|
||||
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
|
||||
item.quality = item.quality - 1;
|
||||
}
|
||||
}
|
||||
} else {
|
||||
if (item.quality < 50) {
|
||||
item.quality = item.quality + 1;
|
||||
|
||||
if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
|
||||
if (item.sellIn < 11) {
|
||||
if (item.quality < 50) {
|
||||
item.quality = item.quality + 1;
|
||||
}
|
||||
}
|
||||
|
||||
if (item.sellIn < 6) {
|
||||
if (item.quality < 50) {
|
||||
item.quality = item.quality + 1;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
*/
|
||||
|
||||
|
||||
|
||||
/* if (newSellIn < 0) {
|
||||
if (!item.name.equals("Aged Brie")) {
|
||||
if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
|
||||
if (item.quality > 0) {
|
||||
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
|
||||
item.quality = item.quality - 1;
|
||||
}
|
||||
}
|
||||
} else {
|
||||
item.quality = item.quality - item.quality;
|
||||
}
|
||||
} else {
|
||||
if (item.quality < 50) {
|
||||
item.quality = item.quality + 1;
|
||||
}
|
||||
}
|
||||
}*/
|
||||
|
||||
item.quality = newQuality;
|
||||
item.sellIn = newSellIn;
|
||||
}
|
||||
|
||||
@ -10,7 +10,7 @@ public class AgedBrieQualityRule implements QualityRule {
|
||||
}
|
||||
|
||||
@Override
|
||||
public Result calculateQuality(int oldQuality, int sellIn) {
|
||||
public Result calculateQuality(int oldQuality, int newSellIn) {
|
||||
return new Result(min(oldQuality + 1, 50), true);
|
||||
}
|
||||
}
|
||||
|
||||
@ -10,14 +10,14 @@ public class BackstagePassQualityRule implements QualityRule {
|
||||
}
|
||||
|
||||
@Override
|
||||
public Result calculateQuality(int oldQuality, int sellIn) {
|
||||
public Result calculateQuality(int oldQuality, int newSellIn) {
|
||||
final int newQuality;
|
||||
|
||||
if (sellIn < 0) {
|
||||
if (newSellIn < 0) {
|
||||
newQuality = 0;
|
||||
} else if (sellIn < 5) {
|
||||
} else if (newSellIn < 5) {
|
||||
newQuality = oldQuality + 3;
|
||||
} else if (sellIn < 10) {
|
||||
} else if (newSellIn < 10) {
|
||||
newQuality = oldQuality + 2;
|
||||
} else {
|
||||
newQuality = oldQuality + 1;
|
||||
|
||||
@ -10,9 +10,9 @@ public class DefaultQualityRule implements QualityRule {
|
||||
}
|
||||
|
||||
@Override
|
||||
public Result calculateQuality(int oldQuality, int sellIn) {
|
||||
public Result calculateQuality(int oldQuality, int newSellIn) {
|
||||
final int newQuality;
|
||||
if (sellIn < 0) {
|
||||
if (newSellIn < 0) {
|
||||
newQuality = oldQuality - 2;
|
||||
} else {
|
||||
newQuality = oldQuality - 1;
|
||||
|
||||
@ -1,7 +1,8 @@
|
||||
package com.gildedrose.rules;
|
||||
|
||||
public interface QualityRule {
|
||||
|
||||
boolean shouldApply(String itemName);
|
||||
|
||||
Result calculateQuality(int oldQuality, int sellIn);
|
||||
Result calculateQuality(int oldQuality, int newSellIn);
|
||||
}
|
||||
|
||||
@ -8,7 +8,7 @@ public class SulfurasQualityRule implements QualityRule {
|
||||
}
|
||||
|
||||
@Override
|
||||
public Result calculateQuality(int oldQuality, int sellIn) {
|
||||
public Result calculateQuality(int oldQuality, int newSellIn) {
|
||||
return new Result(oldQuality, true);
|
||||
}
|
||||
}
|
||||
|
||||
Loading…
Reference in New Issue
Block a user