OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 06:21:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cleanup

Browse Source
This commit is contained in:
Konstantin Pavlov 2019-06-30 06:58:11 +02:00
parent f23572d512
commit bef68f0068
6 changed files with 10 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -46,55 +46,6 @@ class GildedRose {
}, },
(a, b) -> b).getQuality(); (a, b) -> b).getQuality();
/*
if (!item.name.equals("Aged Brie")
&& !item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality > 0) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
item.quality = item.quality - 1;
}
}
} else {
if (item.quality < 50) {
item.quality = item.quality + 1;
if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.sellIn < 11) {
if (item.quality < 50) {
item.quality = item.quality + 1;
}
}
if (item.sellIn < 6) {
if (item.quality < 50) {
item.quality = item.quality + 1;
}
}
}
}
}
*/
/* if (newSellIn < 0) {
if (!item.name.equals("Aged Brie")) {
if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality > 0) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
item.quality = item.quality - 1;
}
}
} else {
item.quality = item.quality - item.quality;
}
} else {
if (item.quality < 50) {
item.quality = item.quality + 1;
}
}
}*/
item.quality = newQuality; item.quality = newQuality;
item.sellIn = newSellIn; item.sellIn = newSellIn;
} }

2
Java/src/main/java/com/gildedrose/rules/AgedBrieQualityRule.java
View File

@ -10,7 +10,7 @@ public class AgedBrieQualityRule implements QualityRule {
} }
@Override @Override
public Result calculateQuality(int oldQuality, int sellIn) { public Result calculateQuality(int oldQuality, int newSellIn) {
return new Result(min(oldQuality + 1, 50), true); return new Result(min(oldQuality + 1, 50), true);
} }
} }

8
Java/src/main/java/com/gildedrose/rules/BackstagePassQualityRule.java
View File

@ -10,14 +10,14 @@ public class BackstagePassQualityRule implements QualityRule {
} }
@Override @Override
public Result calculateQuality(int oldQuality, int sellIn) { public Result calculateQuality(int oldQuality, int newSellIn) {
final int newQuality; final int newQuality;
if (sellIn < 0) { if (newSellIn < 0) {
newQuality = 0; newQuality = 0;
} else if (sellIn < 5) { } else if (newSellIn < 5) {
newQuality = oldQuality + 3; newQuality = oldQuality + 3;
} else if (sellIn < 10) { } else if (newSellIn < 10) {
newQuality = oldQuality + 2; newQuality = oldQuality + 2;
} else { } else {
newQuality = oldQuality + 1; newQuality = oldQuality + 1;

4
Java/src/main/java/com/gildedrose/rules/DefaultQualityRule.java
View File

@ -10,9 +10,9 @@ public class DefaultQualityRule implements QualityRule {
} }
@Override @Override
public Result calculateQuality(int oldQuality, int sellIn) { public Result calculateQuality(int oldQuality, int newSellIn) {
final int newQuality; final int newQuality;
if (sellIn < 0) { if (newSellIn < 0) {
newQuality = oldQuality - 2; newQuality = oldQuality - 2;
} else { } else {
newQuality = oldQuality - 1; newQuality = oldQuality - 1;

3
Java/src/main/java/com/gildedrose/rules/QualityRule.java
View File

@ -1,7 +1,8 @@
package com.gildedrose.rules; package com.gildedrose.rules;
public interface QualityRule { public interface QualityRule {
boolean shouldApply(String itemName); boolean shouldApply(String itemName);
Result calculateQuality(int oldQuality, int sellIn); Result calculateQuality(int oldQuality, int newSellIn);
} }

2
Java/src/main/java/com/gildedrose/rules/SulfurasQualityRule.java
View File

@ -8,7 +8,7 @@ public class SulfurasQualityRule implements QualityRule {
} }
@Override @Override
public Result calculateQuality(int oldQuality, int sellIn) { public Result calculateQuality(int oldQuality, int newSellIn) {
return new Result(oldQuality, true); return new Result(oldQuality, true);
} }
} }