OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Rename some methods

Browse Source
This commit is contained in:
Remus Decea 2023-11-13 11:02:11 +02:00
parent fbc21a54c6
commit bf4fe8a02f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -20,11 +20,11 @@ class GildedRose {
Item[] otherItems = Arrays.stream(agingItems).filter(i -> !i.name.equals(backStagePasses) && !i.name.equals(agedBrie)).toArray(Item[]::new); Item[] otherItems = Arrays.stream(agingItems).filter(i -> !i.name.equals(backStagePasses) && !i.name.equals(agedBrie)).toArray(Item[]::new);
for (Item item : otherItems) { for (Item item : otherItems) {
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;
decreaseQualityOfNormalItems(item); changeQualityOfStandardItems(item);
} }
for (Item brie : bries) { for (Item brie : bries) {
brie.sellIn = brie.sellIn - 1; brie.sellIn = brie.sellIn - 1;
increaseQualityOfBries(brie); changeQualityOfBries(brie);
} }
for (Item item : backstagePasses) { for (Item item : backstagePasses) {
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;
@ -40,12 +40,12 @@ class GildedRose {
return Math.min(item.quality + factor, 50); return Math.min(item.quality + factor, 50);
} }
private void decreaseQualityOfNormalItems(Item item) { private void changeQualityOfStandardItems(Item item) {
int decreaseFactor = (item.sellIn > 0) ? 1 : 2; int decreaseFactor = (item.sellIn > 0) ? 1 : 2;
item.quality = getDecreasedQuality(item.quality, decreaseFactor); item.quality = getDecreasedQuality(item.quality, decreaseFactor);
} }
private void increaseQualityOfBries(Item item) { private void changeQualityOfBries(Item item) {
int increaseFactor = (item.sellIn > 0) ? 1 : 2; int increaseFactor = (item.sellIn > 0) ? 1 : 2;
item.quality = getIncreasedQuality(item, increaseFactor); item.quality = getIncreasedQuality(item, increaseFactor);
} }