OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 06:21:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

moved specific logic in objects

Browse Source
This commit is contained in:
Sallah Kokaina 2019-11-01 19:52:49 +01:00
parent 58220c2358
commit c02dc07db1
5 changed files with 39 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -1,9 +1,6 @@
package com.gildedrose;
import com.gildedrose.item.Backstage;
import com.gildedrose.item.Brie;
import com.gildedrose.item.Item;
import com.gildedrose.item.Sulfuras;
class GildedRose {
Item[] items;
@ -16,56 +13,7 @@ class GildedRose {
for (int i = 0; i < items.length; i++) {
final Item item = items[i];
item.updateSellIn();
if(item.name.equals(Brie.BRIE)){
updateBrieQuality(item);
}else if (item.name.equals(Backstage.BACKSTAGE)){
updateBackstageQuality(item);
}else if (!item.name.equals(Sulfuras.SULFURAS)){
updateItemQuality(item);
}
}
}
private void updateItemQuality(Item item) {
if (!item.name.equals(Backstage.BACKSTAGE)) {
if (item.quality > 0 ) {
item.decreaseQuality();
}
}
else {
if (item.quality < 50) {
item.increaseQuality();
}
}
if (item.sellIn < 0) {
if (!item.name.equals(Backstage.BACKSTAGE)) {
if ( item.quality > 0) {
item.decreaseQuality();
}
} else {
item.quality = 0;
}
}
}
private void updateBackstageQuality(Item item) {
if (item.quality < 50) {
item.increaseQuality();
}
if (item.sellIn < 0) {
item.quality = 0;
}
}
private void updateBrieQuality(Item item) {
if (item.quality < 50) {
item.increaseQuality();
}
if (item.sellIn < 0) {
if (item.quality < 50) {
item.increaseQuality();
}
item.updateQuality();
}
}

12
Java/src/main/java/com/gildedrose/item/Backstage.java
View File

@ -11,13 +11,21 @@ public class Backstage extends Item {
@Override
public void increaseQuality() {
super.increaseQuality();
if (this.sellIn < 11 && this.quality < 50) {
super.increaseQuality();
}
if (this.sellIn < 6 && this.quality < 50) {
super.increaseQuality();
}
}
@Override
public void updateQuality() {
if (this.quality < 50) {
this.increaseQuality();
}
if (this.sellIn < 0) {
this.quality = 0;
}
}
}

12
Java/src/main/java/com/gildedrose/item/Brie.java
View File

@ -14,4 +14,16 @@ public class Brie extends Item {
super.increaseQuality();
}
}
@Override
public void updateQuality(){
if (this.quality < 50) {
this.increaseQuality();
}
if (this.sellIn < 0) {
if (this.quality < 50) {
this.increaseQuality();
}
}
}
}

11
Java/src/main/java/com/gildedrose/item/Item.java
View File

@ -27,6 +27,17 @@ public class Item {
this.quality = this.quality + 1;
}
public void updateQuality(){
if (this.quality > 0) {
this.decreaseQuality();
}
if (this.sellIn < 0) {
if (this.quality > 0) {
this.decreaseQuality();
}
}
}
public void updateSellIn() {
this.sellIn = this.sellIn - 1;
}

5
Java/src/main/java/com/gildedrose/item/Sulfuras.java
View File

@ -12,4 +12,9 @@ public class Sulfuras extends Item {
public void updateSellIn() {
//NO-OP
}
@Override
public void updateQuality() {
//NO-OP
}
}