OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Extract some methods to clean up code

Browse Source
This commit is contained in:
Kacper Majczak 2022-09-12 13:18:47 +02:00
parent e0ab06959b
commit c10371164c
1 changed files with 36 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

71
php/src/GildedRose.php
View File

@ -22,56 +22,57 @@ final class GildedRose
public function updateQuality(): void public function updateQuality(): void
{ {
foreach ($this->items as $item) { foreach ($this->items as $item) {
if ($item->name != self::AGED_BRIE && $item->name != self::BACKSTAGE_PASSES_TO_A_TAFKAL_80_ETC_CONCERT) {
if ($item->quality > 0) {
if ($item->name != self::SULFURAS_HAND_OF_RAGNAROS) {
$item->quality -= 1;
}
}
} else {
if ($item->quality < 50) {
$item->quality += 1;
if ($item->name == self::BACKSTAGE_PASSES_TO_A_TAFKAL_80_ETC_CONCERT) {
if ($item->sell_in < 11) {
if ($item->quality < 50) {
$item->quality += 1;
}
}
if ($item->sell_in < 6) {
if ($item->quality < 50) {
$item->quality += 1;
}
}
}
}
}
if ($item->name != self::SULFURAS_HAND_OF_RAGNAROS) { if ($item->name != self::SULFURAS_HAND_OF_RAGNAROS) {
$item->sell_in -= 1; $item->sell_in -= 1;
} }
if ($item->name != self::AGED_BRIE && $item->name != self::BACKSTAGE_PASSES_TO_A_TAFKAL_80_ETC_CONCERT) {
if ($item->name != self::SULFURAS_HAND_OF_RAGNAROS) {
$this->decreaseItemQuality($item);
if ($this->isSellDatePassed($item)) {
$this->decreaseItemQuality($item);
}
}
} else {
$this->increaseItemQuality($item);
if ($item->name == self::BACKSTAGE_PASSES_TO_A_TAFKAL_80_ETC_CONCERT) {
if ($item->sell_in <= 10) {
$this->increaseItemQuality($item);
}
if ($item->sell_in <= 5) {
$this->increaseItemQuality($item);
}
}
}
if ($this->isSellDatePassed($item)) { if ($this->isSellDatePassed($item)) {
if ($item->name != self::AGED_BRIE) { if ($item->name != self::AGED_BRIE) {
if ($item->name != self::BACKSTAGE_PASSES_TO_A_TAFKAL_80_ETC_CONCERT) { if ($item->name === self::BACKSTAGE_PASSES_TO_A_TAFKAL_80_ETC_CONCERT) {
if ($item->quality > 0) {
if ($item->name != self::SULFURAS_HAND_OF_RAGNAROS) {
$item->quality -= 1;
}
}
} else {
$item->quality = 0; $item->quality = 0;
} }
} else { } else {
if ($item->quality < 50) { $this->increaseItemQuality($item);
$item->quality += 1;
}
} }
} }
} }
} }
private function isSellDatePassed($item): bool private function isSellDatePassed(Item $item): bool
{ {
return $item->sell_in < 0; return $item->sell_in < 0;
} }
private function increaseItemQuality(Item $item): void
{
if ($item->quality < 50) {
$item->quality += 1;
}
}
private function decreaseItemQuality(Item $item): void
{
if ($item->quality > 0) {
$item->quality -= 1;
}
}
} }