From c5c09385d4a5d5fada8659e7e168138cee222fd3 Mon Sep 17 00:00:00 2001
From: Ludwig V <ludwig@getluko.com>
Date: Thu, 11 Nov 2021 16:48:00 +0100
Subject: [PATCH] is outdated

---
 TypeScript/src/gilded-rose.ts | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/TypeScript/src/gilded-rose.ts b/TypeScript/src/gilded-rose.ts
index e17d904c..747ecfc1 100644
--- a/TypeScript/src/gilded-rose.ts
+++ b/TypeScript/src/gilded-rose.ts
@@ -23,8 +23,9 @@ export class GildedRose {
   }
 
   // est périmité ?
-  // should increase quality ?
-
+  isOutdated(item: Item) {
+    return item.sellIn < 0
+  }
   shouldDecreaseQuality(item: Item) {
     return (
       item.name != 'Aged Brie' &&
@@ -53,19 +54,19 @@ export class GildedRose {
       const currentProductName = item.name
       // PART 1
       if (this.shouldDecreaseQuality(item)) {
-        item.quality = item.quality - 1
+        item.quality = this.decrementQuality(item)
       } else {
         if (item.quality < Item.maxQualityThreshold) {
-          item.quality = item.quality + 1
+          item.quality = this.incrementQuality(item)
           if (currentProductName == 'Backstage passes to a TAFKAL80ETC concert') {
             if (item.sellIn < 11) {
               if (item.quality < Item.maxQualityThreshold) {
-                item.quality = item.quality + 1
+                item.quality = this.incrementQuality(item)
               }
             }
             if (item.sellIn < 6) {
               if (item.quality < Item.maxQualityThreshold) {
-                item.quality = item.quality + 1
+                item.quality = this.incrementQuality(item)
               }
             }
           }
@@ -74,18 +75,18 @@ export class GildedRose {
       // part 2
       item.sellIn = item.sellIn - 1
       // part 3
-      if (item.sellIn < 0) {
+      if (this.isOutdated(item)) {
         if (currentProductName != 'Aged Brie') {
           if (currentProductName != 'Backstage passes to a TAFKAL80ETC concert') {
             if (item.quality > Item.minQualityThreshold) {
-              item.quality = item.quality - 1
+              item.quality = this.decrementQuality(item)
             }
           } else {
             item.quality = item.quality - item.quality
           }
         } else {
           if (item.quality < Item.maxQualityThreshold) {
-            item.quality = item.quality + 1
+            item.quality = this.incrementQuality(item)
           }
         }
       }