OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cleanup private methods

Browse Source
This commit is contained in:
Bart Van der Plancken 2020-02-06 22:05:40 +01:00
parent 23246cb741
commit c88bfb0b69
1 changed files with 32 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -17,10 +17,11 @@ class GildedRose {
public void updateQuality() { public void updateQuality() {
for (int i = 0; i < items.length; i++) { for (int i = 0; i < items.length; i++) {
Item item = items[i]; Item item = items[i];
if(isLegendaryItem(item)) { if(isLegendaryItem(item.name)) {
continue; continue;
} }
if (isEnhancingItem(item)) { // update quality
if (isEnhancingItem(item.name)) {
int qualityOffset = determineEnhancingQualityOffset(item); int qualityOffset = determineEnhancingQualityOffset(item);
item.quality = Integer.min(item.quality + qualityOffset, MAX_QUALITY); item.quality = Integer.min(item.quality + qualityOffset, MAX_QUALITY);
} else { } else {
@ -30,25 +31,26 @@ class GildedRose {
} }
item.quality = Integer.max(MIN_QUALITY, item.quality - qualityOffset); item.quality = Integer.max(MIN_QUALITY, item.quality - qualityOffset);
} }
// update sell in value
item.sellIn -= 1; item.sellIn -= 1;
} }
} }
/** /**
* @param item * @param name
* @return * @return
*/ */
private boolean isLegendaryItem(Item item) { private boolean isLegendaryItem(String name) {
return item.name.equals(SULFURAS_HAND_OF_RAGNAROS); return name.equals(SULFURAS_HAND_OF_RAGNAROS);
} }
/** /**
* @param item * @param name
* @return * @return
*/ */
private boolean isEnhancingItem(Item item) { private boolean isEnhancingItem(String name) {
return item.name.equals(GildedRose.AGED_BRIE) || item.name.equals(BACKSTAGE_PASSES); return name.equals(GildedRose.AGED_BRIE) || name.equals(BACKSTAGE_PASSES);
} }
/** /**
@ -58,37 +60,40 @@ class GildedRose {
private int determineEnhancingQualityOffset(Item item) { private int determineEnhancingQualityOffset(Item item) {
int qualityOffset = 1; int qualityOffset = 1;
if (item.name.equals(BACKSTAGE_PASSES)) { if (item.name.equals(BACKSTAGE_PASSES)) {
if (isExperingSale(item)) { if (isExpiredSale(item.sellIn)) {
qualityOffset += 1;
}
if (isUrgentSale(item)) {
qualityOffset += 1;
}
}
if (item.sellIn <= 0) {
if( item.name.equals(AGED_BRIE)) {
qualityOffset += 1;
} else {
qualityOffset = -item.quality; qualityOffset = -item.quality;
} else if (isUrgentSale(item.sellIn)) {
qualityOffset += 2;
} else if (isExperingSale(item.sellIn)) {
qualityOffset += 1;
} }
} else if (isExpiredSale(item.sellIn)) {
qualityOffset += 1;
} }
return qualityOffset; return qualityOffset;
} }
/** /**
* @param item * @param sellIn
* @return * @return
*/ */
private boolean isUrgentSale(Item item) { private boolean isExpiredSale(int sellIn) {
return item.sellIn < 6; return sellIn <= 0;
} }
/** /**
* @param item * @param sellIn
* @return * @return
*/ */
private boolean isExperingSale(Item item) { private boolean isUrgentSale(int sellIn) {
return item.sellIn < 11; return sellIn < 6;
}
/**
* @param sellIn
* @return
*/
private boolean isExperingSale(int sellIn) {
return sellIn < 11;
} }
} }