OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 22:41:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge 9071e804c0 into d0d6fdb93c

Browse Source
This commit is contained in:
matiasalessandrini 2023-07-03 18:30:23 +00:00 committed by GitHub
commit c8d20d4e1c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 184 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -1,62 +1,22 @@
package com.gildedrose;
import com.gildedrose.business.ItemHandler;
import com.gildedrose.business.ItemHandlerFactory;
class GildedRose {
Item[] items;
ItemHandlerFactory itemHandlerFactory;
public GildedRose(Item[] items) {
this.items = items;
this.itemHandlerFactory = new ItemHandlerFactory();
}
public void updateQuality() {
for (int i = 0; i < items.length; i++) {
if (!items[i].name.equals("Aged Brie")
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].sellIn < 11) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
if (items[i].sellIn < 6) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
}
}
}
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].sellIn = items[i].sellIn - 1;
}
if (items[i].sellIn < 0) {
if (!items[i].name.equals("Aged Brie")) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
}
} else {
items[i].quality = items[i].quality - items[i].quality;
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
}
for (Item item: items){
ItemHandler itemHandler = itemHandlerFactory.createItemHandler(item.name);
itemHandler.updateItem(item);
}
}
}
}

19
Java/src/main/java/com/gildedrose/business/AgedBrieItemHandler.java Normal file
View File

@ -0,0 +1,19 @@
package com.gildedrose.business;
import com.gildedrose.Item;
public class AgedBrieItemHandler implements ItemHandler {
@Override
public void updateItem(Item item) {
if (item.quality < 50) {
incrementQuality(item);
}
decrementSellIn(item);
if (hasExpired(item) && item.quality < 50) {
incrementQuality(item);
}
}
}

23
Java/src/main/java/com/gildedrose/business/BackstagePassesItemHandler.java Normal file
View File

@ -0,0 +1,23 @@
package com.gildedrose.business;
import com.gildedrose.Item;
public class BackstagePassesItemHandler implements ItemHandler{
@Override
public void updateItem(Item item) {
if (item.quality < 50) {
incrementQuality(item);
if (item.sellIn < 11 && item.quality < 50) {
incrementQuality(item);
}
if (item.sellIn < 6 && item.quality < 50) {
incrementQuality(item);
}
}
decrementSellIn(item);
if (hasExpired(item)) {
item.quality = 0;
}
}
}

20
Java/src/main/java/com/gildedrose/business/ConjuredItemHandler.java Normal file
View File

@ -0,0 +1,20 @@
package com.gildedrose.business;
import com.gildedrose.Item;
public class ConjuredItemHandler implements ItemHandler {
@Override
public void updateItem(Item item) {
if (item.quality > 0) {
decrementQuality(item);
decrementQuality(item);
}
decrementSellIn(item);
if (hasExpired(item) && item.quality > 0) {
decrementQuality(item);
decrementQuality(item);
}
}
}

18
Java/src/main/java/com/gildedrose/business/ItemEnum.java Normal file
View File

@ -0,0 +1,18 @@
package com.gildedrose.business;
public enum ItemEnum {
AGED_BRIE("Aged Brie"),
SULFURAS("Sulfuras, Hand of Ragnaros"),
BACKSTAGE_PASSES("Backstage passes to a TAFKAL80ETC concert"),
CONJURED_MANA_CAKE("Conjured Mana Cake");
private final String value;
ItemEnum(String value) {
this.value = value;
}
public String getValue() {
return value;
}
}

24
Java/src/main/java/com/gildedrose/business/ItemHandler.java Normal file
View File

@ -0,0 +1,24 @@
package com.gildedrose.business;
import com.gildedrose.Item;
public interface ItemHandler {
void updateItem(Item item);
default void incrementQuality(Item item){
item.quality++;
}
default void decrementQuality(Item item){
item.quality--;
}
default void decrementSellIn(Item item){
item.sellIn--;
}
default boolean hasExpired(Item item) {
return item.sellIn < 0;
}
}

21
Java/src/main/java/com/gildedrose/business/ItemHandlerFactory.java Normal file
View File

@ -0,0 +1,21 @@
package com.gildedrose.business;
public class ItemHandlerFactory {
public ItemHandler createItemHandler(String itemName) {
if (ItemEnum.AGED_BRIE.getValue().equals(itemName)) {
return new AgedBrieItemHandler();
} else if (ItemEnum.BACKSTAGE_PASSES.getValue().equals(itemName)) {
return new BackstagePassesItemHandler();
} else if (ItemEnum.CONJURED_MANA_CAKE.getValue().equals(itemName)) {
return new ConjuredItemHandler();
} else {
return new RegularItemHandler();
}
}
}

26
Java/src/main/java/com/gildedrose/business/RegularItemHandler.java Normal file
View File

@ -0,0 +1,26 @@
package com.gildedrose.business;
import com.gildedrose.Item;
import java.util.Arrays;
import java.util.List;
public class RegularItemHandler implements ItemHandler {
private static final List<String> LEGENDARY_ITEMS = Arrays.asList(new String[]{ItemEnum.SULFURAS.getValue()});
@Override
public void updateItem(Item item) {
if (!LEGENDARY_ITEMS.contains(item.name)) {
if (item.quality > 0) {
decrementQuality(item);
}
decrementSellIn(item);
if (hasExpired(item) && item.quality > 0) {
decrementQuality(item);
}
}
}
}

30
Java/src/test/java/com/gildedrose/GildedRoseTest.java
View File

@ -1,17 +1,35 @@
package com.gildedrose;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource;
import static org.junit.jupiter.api.Assertions.assertEquals;
class GildedRoseTest {
public class GildedRoseTest {
@Test
void foo() {
Item[] items = new Item[] { new Item("foo", 0, 0) };
@ParameterizedTest
@DisplayName("Test updateQuality method")
@CsvSource({
"+5 Dexterity Vest, 10, 20, 9, 19",
"Elixir of the Mongoose, 0, 2, -1, 0",
"Aged Brie, 10, 20, 9, 21",
"Aged Brie, 10, 50, 9, 50",
"Aged Brie, 0, 10, -1, 12",
"'Sulfuras, Hand of Ragnaros', 10, 80, 10, 80",
"Backstage passes to a TAFKAL80ETC concert, 10, 30, 9, 32",
"Backstage passes to a TAFKAL80ETC concert, 5, 30, 4, 33",
"Backstage passes to a TAFKAL80ETC concert, 0, 30, -1, 0",
"Conjured Mana Cake, 10, 20, 9, 18",
"Conjured Mana Cake, 0, 4, -1, 0"
})
void testItemQuality(String itemName, int sellIn, int quality, int expectedSellIn, int expectedQuality) {
Item item = new Item(itemName, sellIn, quality);
Item[] items = new Item[] { item };
GildedRose app = new GildedRose(items);
app.updateQuality();
assertEquals("fixme", app.items[0].name);
assertEquals(expectedSellIn, item.sellIn);
assertEquals(expectedQuality, item.quality);
}
}