r extract func

gilded_rose.py

@@ -1,13 +1,22 @@
-# -*- coding: utf-8 -*-
+class Item:
+    def __init__(self, name, sell_in, quality):
+        self.name = name
+        self.sell_in = sell_in
+        self.quality = quality
 
-class GildedRose(object):
+    def __repr__(self):
+        return "%s, %s, %s" % (self.name, self.sell_in, self.quality)
 
-    def __init__(self, items):
+
+class GildedRose:
+    def __init__(self, items: list[Item]):
         self.items = items
 
-    def update_quality(self):
+    def update_item(self, item):
-        for item in self.items:
+        if (
-            if item.name != "Aged Brie" and item.name != "Backstage passes to a TAFKAL80ETC concert":
+            item.name != "Aged Brie"
+            and item.name != "Backstage passes to a TAFKAL80ETC concert"
+        ):
             if item.quality > 0:
                 if item.name != "Sulfuras, Hand of Ragnaros":
                     item.quality = item.quality - 1
@@ -35,12 +44,6 @@ class GildedRose(object):
                 if item.quality < 50:
                     item.quality = item.quality + 1
 
-
+    def update_quality(self):
-class Item:
+        for item in self.items:
-    def __init__(self, name, sell_in, quality):
+            self.update_item(item)
-        self.name = name
-        self.sell_in = sell_in
-        self.quality = quality
-
-    def __repr__(self):
-        return "%s, %s, %s" % (self.name, self.sell_in, self.quality)

test_gilded_rose.py

@@ -5,12 +5,6 @@ from approvaltests.combination_approvals import verify_all_combinations
 
 
 class GildedRoseTest(unittest.TestCase):
-    def do_stuff(self, name, sell_in, quality):
-        item = Item(name, sell_in, quality)
-        gilded_rose = GildedRose([item])
-        gilded_rose.update_quality()
-        return str(item)
-
     def test_update_quality(self):
         input_names = [
             "foo",
@@ -29,3 +23,9 @@ class GildedRoseTest(unittest.TestCase):
                 input_qualities,
             ],
         )
+
+    def do_stuff(self, name, sell_in, quality):
+        item = Item(name, sell_in, quality)
+        gilded_rose = GildedRose([item])
+        gilded_rose.update_quality()
+        return str(item)