OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 07:51:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor GildedRose class using Strategy Pattern for item update quality

Browse Source
This commit is contained in:
Behnam Nikbakht 2023-08-09 09:25:20 -06:00
parent ee4e35a2f8
commit cbe262583e
1 changed files with 89 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

141
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -1,62 +1,99 @@
package com.gildedrose; package com.gildedrose;
class GildedRose { import java.util.HashMap;
Item[] items; import java.util.Map;
public GildedRose(Item[] items) { class GildedRose {
this.items = items;
private final static int MIN_QUALITY = 0;
private final static int MAX_QUALITY = 50;
private final Item[] items;
private final Map<String, UpdateQualityStrategy> strategyMap;
private interface UpdateQualityStrategy {
void updateQuality(Item item);
} }
public void updateQuality() { private static class NormalItemUpdateStrategy implements UpdateQualityStrategy {
for (int i = 0; i < items.length; i++) { @Override
if (!items[i].name.equals("Aged Brie") public void updateQuality(Item item) {
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (item.quality > MIN_QUALITY) {
if (items[i].quality > 0) { item.quality = item.quality - 1;
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].sellIn < 11) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
if (items[i].sellIn < 6) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
}
}
} }
item.sellIn = item.sellIn - 1;
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (item.sellIn < 0 && item.quality > MIN_QUALITY) {
items[i].sellIn = items[i].sellIn - 1; item.quality = item.quality - 1;
}
if (items[i].sellIn < 0) {
if (!items[i].name.equals("Aged Brie")) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
}
} else {
items[i].quality = items[i].quality - items[i].quality;
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
} }
} }
} }
}
private static class BackstagePassesUpdateStrategy implements UpdateQualityStrategy {
@Override
public void updateQuality(Item item) {
if (item.quality < MAX_QUALITY) {
item.quality = item.quality + 1;
if (item.sellIn < 11 && item.quality < MAX_QUALITY) {
item.quality = item.quality + 1;
}
if (item.sellIn < 6 && item.quality < MAX_QUALITY) {
item.quality = item.quality + 1;
}
}
item.sellIn = item.sellIn - 1;
if (item.sellIn < MIN_QUALITY) {
item.quality = MIN_QUALITY;
}
}
}
private static class AgedBrieUpdateStrategy implements UpdateQualityStrategy {
@Override
public void updateQuality(Item item) {
if (item.quality < MAX_QUALITY) {
item.quality = item.quality + 1;
}
item.sellIn = item.sellIn - 1;
if (item.sellIn < MIN_QUALITY && item.quality < MAX_QUALITY) {
item.quality = item.quality + 1;
}
}
}
private static class SulfurasUpdateStrategy implements UpdateQualityStrategy {
@Override
public void updateQuality(Item item) {
// do nothing
}
}
public GildedRose(Item[] items) {
this.items = items;
this.strategyMap = new HashMap<String, UpdateQualityStrategy>(){{
//default value
put(null, new NormalItemUpdateStrategy());
// update strategies for each possible key
put("Backstage passes to a TAFKAL80ETC concert", new BackstagePassesUpdateStrategy());
put("Aged Brie", new AgedBrieUpdateStrategy());
put("Sulfuras, Hand of Ragnaros", new SulfurasUpdateStrategy());
}};
}
public void updateQuality() {
for (Item item : items) {
UpdateQualityStrategy strategy = strategyMap.getOrDefault(item.name, strategyMap.get(null));
strategy.updateQuality(item);
}
}
}