From cffc1f234cd72eaa85a4e58bdaf8409daf66b2ee Mon Sep 17 00:00:00 2001 From: Christos Giannouris Date: Mon, 14 Nov 2022 13:55:29 +0100 Subject: [PATCH] refactoring duplicated Logic part 2 --- TypeScript/app/gilded-rose.ts | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/TypeScript/app/gilded-rose.ts b/TypeScript/app/gilded-rose.ts index 7626438f..c7f3b107 100644 --- a/TypeScript/app/gilded-rose.ts +++ b/TypeScript/app/gilded-rose.ts @@ -41,16 +41,17 @@ export class GildedRose { iterationItem.sellIn = iterationItem.sellIn - 1; } if (iterationItem.sellIn < 0) { - if (iterationItem.name != CNST.AGED_BRIE) { - if (iterationItem.name != CNST.BCST_TAF) { - if (iterationItem.quality > 0) { - if (iterationItem.name != CNST.SULFURAS) { - iterationItem.quality = iterationItem.quality - 1; - } - } + if ( + iterationItem.name != CNST.AGED_BRIE && + iterationItem.name != CNST.BCST_TAF + ) { + if ( + iterationItem.quality > 0 && + iterationItem.name != CNST.SULFURAS + ) { + iterationItem.quality = iterationItem.quality - 1; } else { - iterationItem.quality = - iterationItem.quality - iterationItem.quality; + iterationItem.quality = 0; } } else { if (iterationItem.quality < 50) {