OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 06:21:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Extract fixture and make it immutable

Browse Source
This commit is contained in:
Ovi Trif 2018-10-05 21:23:30 +02:00
parent 9eedb327ae
commit d187e00d1f
3 changed files with 27 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/test/kotlin/com/gildedrose/GildedRoseTest.kt
View File

@ -1,21 +1,18 @@
package com.gildedrose package com.gildedrose
import com.gildedrose.core.TestUtils
import org.assertj.core.api.Java6Assertions.assertThat import org.assertj.core.api.Java6Assertions.assertThat
import org.junit.Test import org.junit.Test
import java.util.* import java.util.*
class GildedRoseTest { class GildedRoseTest {
private val store = arrayOf( private lateinit var store: Array<Item>
Item("+5 Dexterity Vest", 10, 20), //
Item("Aged Brie", 2, 0), // @Before
Item("Elixir of the Mongoose", 5, 7), // fun setUp() {
Item("Sulfuras, Hand of Ragnaros", 0, 80), // store = TestUtils.fixture
Item("Sulfuras, Hand of Ragnaros", -1, 80), }
Item("Backstage passes to a TAFKAL80ETC concert", 15, 20),
Item("Backstage passes to a TAFKAL80ETC concert", 10, 49),
Item("Backstage passes to a TAFKAL80ETC concert", 5, 49)
)
@Test @Test
fun givenUnknownItem_afterRandomNumberOfDays_shouldDecreaseSellInByNumberOfDays() { fun givenUnknownItem_afterRandomNumberOfDays_shouldDecreaseSellInByNumberOfDays() {

13
src/test/kotlin/com/gildedrose/acceptance/ThirtyDaysAcceptanceTests.kt
View File

@ -3,6 +3,7 @@ package com.gildedrose.acceptance
import com.gildedrose.GildedRose import com.gildedrose.GildedRose
import com.gildedrose.Item import com.gildedrose.Item
import com.gildedrose.core.TestToFileHandler import com.gildedrose.core.TestToFileHandler
import com.gildedrose.core.TestUtils
import org.junit.Assert.assertEquals import org.junit.Assert.assertEquals
import org.junit.Test import org.junit.Test
@ -12,17 +13,7 @@ class ThirtyDaysAcceptanceTests {
@Test @Test
fun withInitialTextFixture_whenRunForThirtyDays_itShouldHaveSameOutputAsLegacyCode() { fun withInitialTextFixture_whenRunForThirtyDays_itShouldHaveSameOutputAsLegacyCode() {
val initialTextFixture = arrayOf( val initialTextFixture = TestUtils.fixture
Item("+5 Dexterity Vest", 10, 20), //
Item("Aged Brie", 2, 0), //
Item("Elixir of the Mongoose", 5, 7), //
Item("Sulfuras, Hand of Ragnaros", 0, 80), //
Item("Sulfuras, Hand of Ragnaros", -1, 80),
Item("Backstage passes to a TAFKAL80ETC concert", 15, 20),
Item("Backstage passes to a TAFKAL80ETC concert", 10, 49),
Item("Backstage passes to a TAFKAL80ETC concert", 5, 49),
// this conjured item does not work properly yet
Item("Conjured Mana Cake", 3, 6))
val output = runWithItemsForDays(initialTextFixture, 30) val output = runWithItemsForDays(initialTextFixture, 30)

18
src/test/kotlin/com/gildedrose/core/TestUtils.kt Normal file
View File

@ -0,0 +1,18 @@
package com.gildedrose.core
import com.gildedrose.Item
object TestUtils {
val fixture
get() = arrayOf(
Item("+5 Dexterity Vest", 10, 20),
Item("Aged Brie", 2, 0),
Item("Elixir of the Mongoose", 5, 7),
Item("Sulfuras, Hand of Ragnaros", 0, 80),
Item("Sulfuras, Hand of Ragnaros", -1, 80),
Item("Backstage passes to a TAFKAL80ETC concert", 15, 20),
Item("Backstage passes to a TAFKAL80ETC concert", 10, 49),
Item("Backstage passes to a TAFKAL80ETC concert", 5, 49),
Item("Conjured Mana Cake", 3, 6))
}