From d80e4d5840d6eda07714592242c2c83aed695e24 Mon Sep 17 00:00:00 2001 From: EmanFateen Date: Sat, 22 Nov 2025 23:21:44 +0200 Subject: [PATCH] chore: remove nested if condition --- php/src/GildedRose.php | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/php/src/GildedRose.php b/php/src/GildedRose.php index e816b8d4..7a0e4cae 100644 --- a/php/src/GildedRose.php +++ b/php/src/GildedRose.php @@ -18,14 +18,14 @@ final class GildedRose public function updateQuality(): void { foreach ($this->items as $item) { - if ($item->name === 'Sulfuras, Hand of Ragnaros') { + if ($item->name === 'Sulfuras, Hand of Ragnaros') continue; - } + if ($item->name === 'Aged Brie') { $item->quality = min(50, ++$item->quality); } else if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') { - if ($item->sellIn < 6) { + if ($item->sellIn <= 5) { $updatedQuality = $item->quality + 3; $item->quality = min(50, $updatedQuality); } else if ($item->sellIn <= 10) { @@ -39,10 +39,9 @@ final class GildedRose $item->sellIn--; - if ($item->sellIn < 0) { - if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') - $item->quality = 0; - } + if ($item->sellIn < 0 && $item->name === 'Backstage passes to a TAFKAL80ETC concert') + $item->quality = 0; + } } }