From d9cbae71696c03357ebb792f27dc244027e9e138 Mon Sep 17 00:00:00 2001 From: Thang Tran Date: Wed, 1 Mar 2023 20:12:32 +0700 Subject: [PATCH] Refactor Code and write Unit test --- php/src/ItemFactory.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/php/src/ItemFactory.php b/php/src/ItemFactory.php index be415b7e..6a379a8b 100644 --- a/php/src/ItemFactory.php +++ b/php/src/ItemFactory.php @@ -25,10 +25,10 @@ class ItemFactory public static function createItem(Item $item): ItemInterface { return match(true) { - strpos($item->name, self::AGED_BRIE_ITEM) !== false => new AgedBrieItem(), - strpos($item->name, self::BACKSTAGE_ITEM) !== false => new BackstagePassItem(), - strpos($item->name, self::SULFURAS_ITEM) !== false => new SulfurasItem(), - strpos($item->name, self::CONJURED_ITEM) !== false => new ConjuredItem(), + str_contains($item->name, self::AGED_BRIE_ITEM) => new AgedBrieItem(), + str_contains($item->name, self::BACKSTAGE_ITEM) => new BackstagePassItem(), + str_contains($item->name, self::SULFURAS_ITEM) => new SulfurasItem(), + str_contains($item->name, self::CONJURED_ITEM) => new ConjuredItem(), default => new NormalItem() }; }