OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 14:31:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cleared the updateSulfurasItem without affecting the test results

Browse Source
This commit is contained in:
Chamoda Ranasinghe 2024-01-16 03:45:48 +07:00
parent ccf3cc6166
commit ddae445fec
No known key found for this signature in database
GPG Key ID: DE81C3C335B7CED3
1 changed files with 6 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
TypeScript/app/gilded-rose.ts
View File

@ -56,15 +56,15 @@ export class GildedRose {
private updateSulfurasItem(item: Item) { private updateSulfurasItem(item: Item) {
assert(item.name == ItemNames.SULFURAS); assert(item.name == ItemNames.SULFURAS);
if (item.quality > 0 && item.name != ItemNames.SULFURAS) { // this function does not update the item (tests are still passing without any logic in this function)
item.quality = item.quality - 1;
}
if (item.sellIn < 0 && item.quality < MAX_ITEM_QUALITY) {
item.quality = item.quality + 1;
}
} }
private updateNormalItem(item: Item) { private updateNormalItem(item: Item) {
assert(
item.name != ItemNames.AGED_BRIE &&
item.name != ItemNames.BACKSTAGE_PASSES &&
item.name != ItemNames.SULFURAS
);
if ( if (
item.name != ItemNames.AGED_BRIE && item.name != ItemNames.AGED_BRIE &&
item.name != ItemNames.BACKSTAGE_PASSES item.name != ItemNames.BACKSTAGE_PASSES
@ -76,18 +76,6 @@ export class GildedRose {
} }
} else if (item.quality < MAX_ITEM_QUALITY) { } else if (item.quality < MAX_ITEM_QUALITY) {
item.quality = item.quality + 1; item.quality = item.quality + 1;
if (item.name == ItemNames.BACKSTAGE_PASSES) {
if (item.sellIn < 11) {
if (item.quality < MAX_ITEM_QUALITY) {
item.quality = item.quality + 1;
}
}
if (item.sellIn < 6) {
if (item.quality < MAX_ITEM_QUALITY) {
item.quality = item.quality + 1;
}
}
}
} }
if (item.name != ItemNames.SULFURAS) { if (item.name != ItemNames.SULFURAS) {
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;