OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2025-12-12 04:12:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #134 from claremacrae/support_cpp11

Browse Source 
Reduce required C++ level from 17 to 11 - no code changes needed.
This commit is contained in:
Emily Bache 2019-12-10 10:03:42 +01:00 committed by GitHub
commit de18a0a661
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/README.md
View File

@ -15,7 +15,7 @@ The `GildedRose.cc` file, i.e. the code under test, is identical in all four var
## Prerequisites ## Prerequisites
* CMake version >= 3.13 * CMake version >= 3.13
* C++ compiler that support C++17 * C++ compiler that support C++11
## How to build and run tests in a terminal ## How to build and run tests in a terminal

2
cpp/test/cpp_catch2_approvaltest/CMakeLists.txt
View File

@ -2,7 +2,7 @@ set(TEST_NAME GildedRoseCatch2ApprovalTests)
add_executable(${TEST_NAME}) add_executable(${TEST_NAME})
target_sources(${TEST_NAME} PRIVATE GildedRoseCatch2ApprovalTests.cc) target_sources(${TEST_NAME} PRIVATE GildedRoseCatch2ApprovalTests.cc)
target_link_libraries(${TEST_NAME} lib src) target_link_libraries(${TEST_NAME} lib src)
set_property(TARGET ${TEST_NAME} PROPERTY CXX_STANDARD 17) set_property(TARGET ${TEST_NAME} PROPERTY CXX_STANDARD 11)
add_test(NAME ${TEST_NAME} COMMAND ${TEST_NAME}) add_test(NAME ${TEST_NAME} COMMAND ${TEST_NAME})
# Set compiler option /FC for Visual Studio to to make the __FILE__ macro expand to full path. # Set compiler option /FC for Visual Studio to to make the __FILE__ macro expand to full path.

2
cpp/test/cpp_catch2_unittest/CMakeLists.txt
View File

@ -2,7 +2,7 @@ set(TEST_NAME GildedRoseCatch2UnitTests)
add_executable(${TEST_NAME}) add_executable(${TEST_NAME})
target_sources(${TEST_NAME} PRIVATE GildedRoseCatch2UnitTests.cc) target_sources(${TEST_NAME} PRIVATE GildedRoseCatch2UnitTests.cc)
target_link_libraries(${TEST_NAME} lib src) target_link_libraries(${TEST_NAME} lib src)
set_property(TARGET ${TEST_NAME} PROPERTY CXX_STANDARD 17) set_property(TARGET ${TEST_NAME} PROPERTY CXX_STANDARD 11)
add_test(NAME ${TEST_NAME} COMMAND ${TEST_NAME}) add_test(NAME ${TEST_NAME} COMMAND ${TEST_NAME})
# Set compiler option /FC for Visual Studio to to make the __FILE__ macro expand to full path. # Set compiler option /FC for Visual Studio to to make the __FILE__ macro expand to full path.

2
cpp/test/cpp_googletest_approvaltest/CMakeLists.txt
View File

@ -2,7 +2,7 @@ set(TEST_NAME GildedRoseGoogletestApprovalTests)
add_executable(${TEST_NAME}) add_executable(${TEST_NAME})
target_sources(${TEST_NAME} PRIVATE googletest_approval_main.cc GildedRoseGoogletestApprovalTests.cc) target_sources(${TEST_NAME} PRIVATE googletest_approval_main.cc GildedRoseGoogletestApprovalTests.cc)
target_link_libraries(${TEST_NAME} lib src gtest) target_link_libraries(${TEST_NAME} lib src gtest)
set_property(TARGET ${TEST_NAME} PROPERTY CXX_STANDARD 17) set_property(TARGET ${TEST_NAME} PROPERTY CXX_STANDARD 11)
add_test(NAME ${TEST_NAME} COMMAND ${TEST_NAME}) add_test(NAME ${TEST_NAME} COMMAND ${TEST_NAME})
# Set compiler option /FC for Visual Studio to to make the __FILE__ macro expand to full path. # Set compiler option /FC for Visual Studio to to make the __FILE__ macro expand to full path.

2
cpp/test/cpp_googletest_unittest/CMakeLists.txt
View File

@ -2,7 +2,7 @@ set(TEST_NAME GildedRoseGoogletestUnitTests)
add_executable(${TEST_NAME}) add_executable(${TEST_NAME})
target_sources(${TEST_NAME} PRIVATE GildedRoseGoogletestUnitTests.cc) target_sources(${TEST_NAME} PRIVATE GildedRoseGoogletestUnitTests.cc)
target_link_libraries(${TEST_NAME} src gtest gtest_main) target_link_libraries(${TEST_NAME} src gtest gtest_main)
set_property(TARGET ${TEST_NAME} PROPERTY CXX_STANDARD 17) set_property(TARGET ${TEST_NAME} PROPERTY CXX_STANDARD 11)
add_test(NAME ${TEST_NAME} COMMAND ${TEST_NAME}) add_test(NAME ${TEST_NAME} COMMAND ${TEST_NAME})
# Set compiler option /FC for Visual Studio to to make the __FILE__ macro expand to full path. # Set compiler option /FC for Visual Studio to to make the __FILE__ macro expand to full path.