OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-10 12:11:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

new practical test

Browse Source
This commit is contained in:
Hussein Mishobo 2025-09-18 13:05:51 +03:00
parent c6f842ef29
commit df2184c18d
4 changed files with 106 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

112
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -1,6 +1,8 @@
package com.gildedrose; package com.gildedrose;
class GildedRose { import com.gildedrose.helper.ItemAgentService;
public class GildedRose {
Item[] items; Item[] items;
public GildedRose(Item[] items) { public GildedRose(Item[] items) {
@ -8,55 +10,69 @@ class GildedRose {
} }
public void updateQuality() { public void updateQuality() {
for (int i = 0; i < items.length; i++) { for (Item item : items) {
if (!items[i].name.equals("Aged Brie") getUpdater(item).update(item);
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { }
if (items[i].quality > 0) { }
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1; public ItemAgentService getUpdater(Item item) {
} switch (item.name) {
} case "Aged Brie":
return new AgedBrieUpdater();
case "Backstage passes to a TAFKAL80ETC concert":
return new BackstagePassUpdater();
case "Sulfuras, Hand of Ragnaros":
return new SulfurasUpdater();
default:
return new NormalItemUpdater();
}
}
public static class NormalItemUpdater implements ItemAgentService {
public void update(Item item) {
item.sellIn--;
if (item.quality > 0) item.quality--;
if (item.sellIn < 0 && item.quality > 0) item.quality--;
}
}
public static class AgedBrieUpdater implements ItemAgentService {
public void update(Item item) {
item.sellIn--;
if (item.quality < 50) item.quality++;
if (item.sellIn < 0 && item.quality < 50) item.quality++;
}
}
public static class BackstagePassUpdater implements ItemAgentService {
public void update(Item item) {
item.sellIn--;
if (item.sellIn < 0) {
item.quality = 0;
} else if (item.sellIn < 5) {
item.quality = Math.min(item.quality + 3, 50);
} else if (item.sellIn < 10) {
item.quality = Math.min(item.quality + 2, 50);
} else { } else {
if (items[i].quality < 50) { item.quality = Math.min(item.quality + 1, 50);
items[i].quality = items[i].quality + 1;
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].sellIn < 11) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
if (items[i].sellIn < 6) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
}
}
}
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].sellIn = items[i].sellIn - 1;
}
if (items[i].sellIn < 0) {
if (!items[i].name.equals("Aged Brie")) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
}
} else {
items[i].quality = items[i].quality - items[i].quality;
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
} }
} }
} }
public static class SulfurasUpdater implements ItemAgentService {
public void update(Item item) {
// Legendary item: no changes
}
}
public static class ConjuredItemUpdater implements ItemAgentService {
public void update(Item item) {
item.sellIn--;
if (item.quality > 0) item.quality -= 2;
if (item.sellIn < 0 && item.quality > 0) item.quality -= 2;
if (item.quality < 0) item.quality = 0; // Prevent negative quality
}
}
} }

7
Java/src/main/java/com/gildedrose/helper/ItemAgentService.java Normal file
View File

@ -0,0 +1,7 @@
package com.gildedrose.helper;
import com.gildedrose.Item;
public interface ItemAgentService {
void update(Item item);
}

20
Java/src/main/java/com/gildedrose/helper/ItemUpdaterFactory.java Normal file
View File

@ -0,0 +1,20 @@
package com.gildedrose.helper;
import com.gildedrose.GildedRose;
import com.gildedrose.Item;
public class ItemUpdaterFactory {
public static ItemAgentService getUpdater(Item item) {
switch (item.name) {
case "Aged Brie":
return new GildedRose.AgedBrieUpdater();
case "Backstage passes to a TAFKAL80ETC concert":
return new GildedRose.BackstagePassUpdater();
case "Sulfuras, Hand of Ragnaros":
return new GildedRose.SulfurasUpdater();
case "Conjured Mana Cake":
return new GildedRose.ConjuredItemUpdater();
default:
return new GildedRose.NormalItemUpdater();
}}
}

18
Java/src/test/java/com/gildedrose/GildedRoseTest.java
View File

@ -7,11 +7,23 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
class GildedRoseTest { class GildedRoseTest {
@Test @Test
void foo() { void normalItemDegrades() {
Item[] items = new Item[] { new Item("foo", 0, 0) }; Item[] items = new Item[] { new Item("foo", 10, 20) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals("fixme", app.items[0].name); assertEquals(9, app.items[0].sellIn);
assertEquals(19, app.items[0].quality);
} }
@Test
void conjuredItemDegradesTwiceAsFast() {
Item[] items = new Item[] { new Item("Conjured Mana Cake", 5, 10) };
GildedRose app = new GildedRose(items);
app.updateQuality();
assertEquals(4, items[0].sellIn);
assertEquals(9, items[0].quality);
}
} }