OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 16:01:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Duplicated Code] extract to function

Browse Source 
for plusOneQuilaty_if_less_than_fifth
This commit is contained in:
jiajun.chou 2020-08-13 21:35:44 +08:00
parent e49d0f62b4
commit e00567ab6a
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -11,23 +11,17 @@ class GildedRose {
for (int i = 0; i < items.length; i++) { for (int i = 0; i < items.length; i++) {
if (items[i].name.equals("Aged Brie")) { if (items[i].name.equals("Aged Brie")) {
if (items[i].quality < 50) { extracted(i);
items[i].quality = items[i].quality + 1;
}
} else if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { } else if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality < 50) { if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1; items[i].quality = items[i].quality + 1;
if (items[i].sellIn < 11) { if (items[i].sellIn < 11) {
if (items[i].quality < 50) { extracted(i);
items[i].quality = items[i].quality + 1;
}
} }
if (items[i].sellIn < 6) { if (items[i].sellIn < 6) {
if (items[i].quality < 50) { extracted(i);
items[i].quality = items[i].quality + 1;
}
} }
} }
} else { } else {
@ -42,9 +36,7 @@ class GildedRose {
if (items[i].sellIn < 0) { if (items[i].sellIn < 0) {
if (items[i].name.equals("Aged Brie")) { if (items[i].name.equals("Aged Brie")) {
if (items[i].quality < 50) { extracted(i);
items[i].quality = items[i].quality + 1;
}
} else { } else {
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
items[i].quality = items[i].quality - items[i].quality; items[i].quality = items[i].quality - items[i].quality;
@ -56,6 +48,12 @@ class GildedRose {
} }
} }
private void extracted(int i) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
private void caculateQuilaty_without_Sulfuras(int i) { private void caculateQuilaty_without_Sulfuras(int i) {
if (items[i].quality > 0) { if (items[i].quality > 0) {
if (items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (items[i].name.equals("Sulfuras, Hand of Ragnaros")) {