OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 22:41:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use consts and change way of assigning properties

Browse Source
This commit is contained in:
Kacper Majczak 2022-09-12 13:05:01 +02:00
parent 44085d93d0
commit e0ab06959b
1 changed files with 24 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
php/src/GildedRose.php
View File

@ -6,6 +6,9 @@ namespace GildedRose;
final class GildedRose final class GildedRose
{ {
private const SULFURAS_HAND_OF_RAGNAROS = 'Sulfuras, Hand of Ragnaros';
private const BACKSTAGE_PASSES_TO_A_TAFKAL_80_ETC_CONCERT = 'Backstage passes to a TAFKAL80ETC concert';
private const AGED_BRIE = 'Aged Brie';
/** /**
* @var Item[] * @var Item[]
*/ */
@ -19,51 +22,56 @@ final class GildedRose
public function updateQuality(): void public function updateQuality(): void
{ {
foreach ($this->items as $item) { foreach ($this->items as $item) {
if ($item->name != 'Aged Brie' and $item->name != 'Backstage passes to a TAFKAL80ETC concert') { if ($item->name != self::AGED_BRIE && $item->name != self::BACKSTAGE_PASSES_TO_A_TAFKAL_80_ETC_CONCERT) {
if ($item->quality > 0) { if ($item->quality > 0) {
if ($item->name != 'Sulfuras, Hand of Ragnaros') { if ($item->name != self::SULFURAS_HAND_OF_RAGNAROS) {
$item->quality = $item->quality - 1; $item->quality -= 1;
} }
} }
} else { } else {
if ($item->quality < 50) { if ($item->quality < 50) {
$item->quality = $item->quality + 1; $item->quality += 1;
if ($item->name == 'Backstage passes to a TAFKAL80ETC concert') { if ($item->name == self::BACKSTAGE_PASSES_TO_A_TAFKAL_80_ETC_CONCERT) {
if ($item->sell_in < 11) { if ($item->sell_in < 11) {
if ($item->quality < 50) { if ($item->quality < 50) {
$item->quality = $item->quality + 1; $item->quality += 1;
} }
} }
if ($item->sell_in < 6) { if ($item->sell_in < 6) {
if ($item->quality < 50) { if ($item->quality < 50) {
$item->quality = $item->quality + 1; $item->quality += 1;
} }
} }
} }
} }
} }
if ($item->name != 'Sulfuras, Hand of Ragnaros') { if ($item->name != self::SULFURAS_HAND_OF_RAGNAROS) {
$item->sell_in = $item->sell_in - 1; $item->sell_in -= 1;
} }
if ($item->sell_in < 0) { if ($this->isSellDatePassed($item)) {
if ($item->name != 'Aged Brie') { if ($item->name != self::AGED_BRIE) {
if ($item->name != 'Backstage passes to a TAFKAL80ETC concert') { if ($item->name != self::BACKSTAGE_PASSES_TO_A_TAFKAL_80_ETC_CONCERT) {
if ($item->quality > 0) { if ($item->quality > 0) {
if ($item->name != 'Sulfuras, Hand of Ragnaros') { if ($item->name != self::SULFURAS_HAND_OF_RAGNAROS) {
$item->quality = $item->quality - 1; $item->quality -= 1;
} }
} }
} else { } else {
$item->quality = $item->quality - $item->quality; $item->quality = 0;
} }
} else { } else {
if ($item->quality < 50) { if ($item->quality < 50) {
$item->quality = $item->quality + 1; $item->quality += 1;
} }
} }
} }
} }
} }
private function isSellDatePassed($item): bool
{
return $item->sell_in < 0;
}
} }