From e0c5b8b5bd3754e79fde7804ebbae3694317763a Mon Sep 17 00:00:00 2001 From: Trobax Date: Wed, 23 Nov 2022 17:04:15 +0100 Subject: [PATCH] update updateQuality method update updateQuality method to process each item individually Aged Brie then Backstage passes then Sulfuras then the rest of items --- .../main/java/com/gildedrose/GildedRose.java | 37 ++++++++----------- 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/Java/src/main/java/com/gildedrose/GildedRose.java b/Java/src/main/java/com/gildedrose/GildedRose.java index 76fa5dc3..99649172 100644 --- a/Java/src/main/java/com/gildedrose/GildedRose.java +++ b/Java/src/main/java/com/gildedrose/GildedRose.java @@ -22,31 +22,26 @@ class GildedRose { } private static void updateQuality(Item item) { - if (item.name.equals("Aged Brie") - || item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { + if (item.name.equals("Aged Brie")) { + if (item.quality < 50) { + item.quality++; + } + } else if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { + if (item.sellIn < 11) { if (item.quality < 50) { item.quality++; - - if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { - if (item.sellIn < 11) { - if (item.quality < 50) { - item.quality++; - } - } - - if (item.sellIn < 6) { - if (item.quality < 50) { - item.quality++; - } - } - } - } - } else { - if (item.quality > 0) { - if (!item.name.equals("Sulfuras, Hand of Ragnaros")) { - item.quality--; } } + + if (item.sellIn < 6) { + if (item.quality < 50) { + item.quality++; + } + } + } else if (item.name.equals("Sulfuras, Hand of Ragnaros")) { + return; + } else if (item.quality > 0) { + item.quality--; } }