OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-09 03:31:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

aug 13 refactoring

Browse Source
This commit is contained in:
ben.nadler 2024-08-13 11:41:27 +03:00
parent 2f93d81eed
commit e97f7da26b
1 changed files with 24 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
TypeScript/app/gilded-rose.ts
View File

@ -1,5 +1,13 @@
enum ItemNames {
AgedBrie = 'Aged Brie',
BackstagePasses = 'Backstage passes to a TAFKAL80ETC concert',
Sulfuras = 'Sulfuras, Hand of Ragnaros'
}
const itemNames = [ItemNames.AgedBrie, ItemNames.BackstagePasses, ItemNames.Sulfuras];
export class Item { export class Item {
name: string; name: string | ItemNames;
sellIn: number; sellIn: number;
quality: number; quality: number;
@ -19,46 +27,25 @@ export class GildedRose {
updateQuality() { updateQuality() {
for (let i = 0; i < this.items.length; i++) { for (let i = 0; i < this.items.length; i++) {
if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') { const item = this.items[i];
if (this.items[i].quality > 0) { if (!itemNames.includes(item.name as ItemNames) && item.quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') { item.quality = item.quality - 1
this.items[i].quality = this.items[i].quality - 1 } else if (item.quality < 50) {
} item.quality = item.quality + 1
} if (item.name == ItemNames.BackstagePasses && item.sellIn < 11) {
} else { item.quality = item.quality + 1
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].sellIn < 11) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
}
if (this.items[i].sellIn < 6) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
}
}
} }
} }
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') { if (item.name != ItemNames.Sulfuras) {
this.items[i].sellIn = this.items[i].sellIn - 1; item.sellIn = item.sellIn - 1;
} }
if (this.items[i].sellIn < 0) { if (item.sellIn < 0) {
if (this.items[i].name != 'Aged Brie') { if (item.name != ItemNames.AgedBrie) {
if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') { const shouldDecreaseQuality = ![ItemNames.BackstagePasses, ItemNames.Sulfuras].includes(item.name as ItemNames) && item.quality > 0;
if (this.items[i].quality > 0) { item.quality = shouldDecreaseQuality ? item.quality - 1 : 0;
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1
}
}
} else {
this.items[i].quality = this.items[i].quality - this.items[i].quality
}
} else { } else {
if (this.items[i].quality < 50) { if (item.quality < 50) {
this.items[i].quality = this.items[i].quality + 1 item.quality = item.quality + 1
} }
} }
} }