OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 14:31:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

To simplify code, remove old business logic

Browse Source
This commit is contained in:
Sam Burns 2024-01-24 15:54:07 +00:00
parent 4562b6d688
commit ea9b680b55
1 changed files with 3 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
php/src/GildedRose.php
View File

@ -32,25 +32,13 @@ final class GildedRose
continue; continue;
} }
if ($item->name !== 'Aged Brie' and $item->name !== 'Backstage passes to a TAFKAL80ETC concert') { if ($item->name !== 'Aged Brie') {
if ($item->quality > 0) { if ($item->quality > 0) {
$item->quality = $item->quality - 1; $item->quality = $item->quality - 1;
} }
} else { } else {
if ($item->quality < 50) { if ($item->quality < 50) {
$item->quality = $item->quality + 1; $item->quality = $item->quality + 1;
if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') {
if ($item->sellIn < 11) {
if ($item->quality < 50) {
$item->quality = $item->quality + 1;
}
}
if ($item->sellIn < 6) {
if ($item->quality < 50) {
$item->quality = $item->quality + 1;
}
}
}
} }
} }
@ -58,13 +46,9 @@ final class GildedRose
if ($item->sellIn < 0) { if ($item->sellIn < 0) {
if ($item->name !== 'Aged Brie') { if ($item->name !== 'Aged Brie') {
if ($item->name !== 'Backstage passes to a TAFKAL80ETC concert') {
if ($item->quality > 0) { if ($item->quality > 0) {
$item->quality = $item->quality - 1; $item->quality = $item->quality - 1;
} }
} else {
$item->quality = $item->quality - $item->quality;
}
} else { } else {
if ($item->quality < 50) { if ($item->quality < 50) {
$item->quality = $item->quality + 1; $item->quality = $item->quality + 1;