OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Replace for array to foreach

Browse Source
This commit is contained in:
jiajun.chou 2020-08-13 21:40:59 +08:00
parent e00567ab6a
commit ef7eb587ec
1 changed files with 27 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -9,57 +9,58 @@ class GildedRose {
public void updateQuality() { public void updateQuality() {
for (int i = 0; i < items.length; i++) { for (Item item : items) {
if (items[i].name.equals("Aged Brie")) { if (item.name.equals("Aged Brie")) {
extracted(i); plusOneQuilaty_if_less_than_fifth(item);
} else if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { } else if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality < 50) { if (item.quality < 50) {
items[i].quality = items[i].quality + 1; item.quality = item.quality + 1;
if (items[i].sellIn < 11) { if (item.sellIn < 11) {
extracted(i); plusOneQuilaty_if_less_than_fifth(item);
} }
if (items[i].sellIn < 6) { if (item.sellIn < 6) {
extracted(i); plusOneQuilaty_if_less_than_fifth(item);
} }
} }
} else { } else {
caculateQuilaty_without_Sulfuras(i); caculateQuilaty_without_Sulfuras(item);
} }
if (items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (item.name.equals("Sulfuras, Hand of Ragnaros")) {
} else { } else {
items[i].sellIn = items[i].sellIn - 1; item.sellIn = item.sellIn - 1;
} }
if (items[i].sellIn < 0) { if (item.sellIn < 0) {
if (items[i].name.equals("Aged Brie")) { if (item.name.equals("Aged Brie")) {
extracted(i); plusOneQuilaty_if_less_than_fifth(item);
} else { } else {
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
items[i].quality = items[i].quality - items[i].quality; item.quality = item.quality - item.quality;
} else { } else {
caculateQuilaty_without_Sulfuras(i); caculateQuilaty_without_Sulfuras(item);
}
} }
} }
} }
} }
private void extracted(int i) { }
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1; private void plusOneQuilaty_if_less_than_fifth(Item item) {
if (item.quality < 50) {
item.quality = item.quality + 1;
} }
} }
private void caculateQuilaty_without_Sulfuras(int i) { private void caculateQuilaty_without_Sulfuras(Item item) {
if (items[i].quality > 0) { if (item.quality > 0) {
if (items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (item.name.equals("Sulfuras, Hand of Ragnaros")) {
} else { } else {
items[i].quality = items[i].quality - 1; item.quality = item.quality - 1;
} }
} }
} }