OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 16:01:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Taking out changes to Item.java

Browse Source
This commit is contained in:
Adam 2022-09-25 18:15:45 +01:00
parent 30ed72f8de
commit f14ff34936
2 changed files with 6 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
Java/src/main/java/com/gildedrose/Item.java
View File

@ -19,31 +19,4 @@ public class Item {
return this.name + ", " + this.sellIn + ", " + this.quality; return this.name + ", " + this.sellIn + ", " + this.quality;
} }
@Override
public boolean equals(Object o) {
if (this == o) {
return true;
}
if (o == null || getClass() != o.getClass()) {
return false;
}
Item item = (Item) o;
if (sellIn != item.sellIn) {
return false;
}
if (quality != item.quality) {
return false;
}
return name != null ? name.equals(item.name) : item.name == null;
}
@Override
public int hashCode() {
int result = name != null ? name.hashCode() : 0;
result = 31 * result + sellIn;
result = 31 * result + quality;
return result;
}
} }

9
Java/src/test/java/com/gildedrose/GildedRoseTest.java
View File

@ -13,7 +13,8 @@ class GildedRoseTest {
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
Item updatedItem = app.items[0]; Item updatedItem = app.items[0];
assertEquals(new Item("test_item", 2, 9), updatedItem); assertEquals(2, updatedItem.sellIn);
assertEquals(9, updatedItem.quality);
} }
@Test @Test
@ -23,7 +24,8 @@ class GildedRoseTest {
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
Item updatedItem = app.items[0]; Item updatedItem = app.items[0];
assertEquals(new Item("test_item", -1, 8), updatedItem); assertEquals(-1, updatedItem.sellIn);
assertEquals(8, updatedItem.quality);
} }
@Test @Test
@ -43,7 +45,8 @@ class GildedRoseTest {
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
Item updatedItem = app.items[0]; Item updatedItem = app.items[0];
assertEquals(new Item("Aged Brie", 4, 11), updatedItem); assertEquals(4, updatedItem.sellIn);
assertEquals(11, updatedItem.quality);
} }
@Test @Test