From f1a9242aac9e1ba49ff73637828c6b5e04bab613 Mon Sep 17 00:00:00 2001
From: Bjorn Misseghers <bjorn.misseghers@unifiedpost.com>
Date: Tue, 6 Apr 2021 20:10:48 +0200
Subject: [PATCH] Extract magic strings and numbers

---
 .../main/java/com/gildedrose/GildedRose.java  | 34 +++++++++++--------
 1 file changed, 20 insertions(+), 14 deletions(-)

diff --git a/Java/src/main/java/com/gildedrose/GildedRose.java b/Java/src/main/java/com/gildedrose/GildedRose.java
index e6feb751..154b4fac 100644
--- a/Java/src/main/java/com/gildedrose/GildedRose.java
+++ b/Java/src/main/java/com/gildedrose/GildedRose.java
@@ -1,6 +1,12 @@
 package com.gildedrose;
 
 class GildedRose {
+    public static final String ITEM_AGED_BRIE = "Aged Brie";
+    public static final String ITEM_SULFURAS_HAND_OF_RAGNAROS = "Sulfuras, Hand of Ragnaros";
+    public static final String ITEM_BACKSTAGE_PASSES = "Backstage passes to a TAFKAL80ETC concert";
+    public static final int MAX_QUALITY_LEVEL = 50;
+    public static final int MIN_QUALITY_LEVEL = 0;
+
     Item[] items;
 
     public GildedRose(Item[] items) {
@@ -9,26 +15,26 @@ class GildedRose {
 
     public void updateQuality() {
         for (int i = 0; i < items.length; i++) {
-            if (!items[i].name.equals("Aged Brie")
-                    && !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
-                if (items[i].quality > 0) {
-                    if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
+            if (!items[i].name.equals(ITEM_AGED_BRIE)
+                    && !items[i].name.equals(ITEM_BACKSTAGE_PASSES)) {
+                if (items[i].quality > MIN_QUALITY_LEVEL) {
+                    if (!items[i].name.equals(ITEM_SULFURAS_HAND_OF_RAGNAROS)) {
                         items[i].quality = items[i].quality - 1;
                     }
                 }
             } else {
-                if (items[i].quality < 50) {
+                if (items[i].quality < MAX_QUALITY_LEVEL) {
                     items[i].quality = items[i].quality + 1;
 
-                    if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
+                    if (items[i].name.equals(ITEM_BACKSTAGE_PASSES)) {
                         if (items[i].sellIn < 11) {
-                            if (items[i].quality < 50) {
+                            if (items[i].quality < MAX_QUALITY_LEVEL) {
                                 items[i].quality = items[i].quality + 1;
                             }
                         }
 
                         if (items[i].sellIn < 6) {
-                            if (items[i].quality < 50) {
+                            if (items[i].quality < MAX_QUALITY_LEVEL) {
                                 items[i].quality = items[i].quality + 1;
                             }
                         }
@@ -36,15 +42,15 @@ class GildedRose {
                 }
             }
 
-            if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
+            if (!items[i].name.equals(ITEM_SULFURAS_HAND_OF_RAGNAROS)) {
                 items[i].sellIn = items[i].sellIn - 1;
             }
 
             if (items[i].sellIn < 0) {
-                if (!items[i].name.equals("Aged Brie")) {
-                    if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
-                        if (items[i].quality > 0) {
-                            if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
+                if (!items[i].name.equals(ITEM_AGED_BRIE)) {
+                    if (!items[i].name.equals(ITEM_BACKSTAGE_PASSES)) {
+                        if (items[i].quality > MIN_QUALITY_LEVEL) {
+                            if (!items[i].name.equals(ITEM_SULFURAS_HAND_OF_RAGNAROS)) {
                                 items[i].quality = items[i].quality - 1;
                             }
                         }
@@ -52,7 +58,7 @@ class GildedRose {
                         items[i].quality = items[i].quality - items[i].quality;
                     }
                 } else {
-                    if (items[i].quality < 50) {
+                    if (items[i].quality < MAX_QUALITY_LEVEL) {
                         items[i].quality = items[i].quality + 1;
                     }
                 }