mirror of
https://github.com/emilybache/GildedRose-Refactoring-Kata.git
synced 2026-02-15 22:41:30 +00:00
Merge pull request #2 from pcroch/feat/adding_test_cases_for_improve_coverage
Feat/adding test cases for improve coverage
This commit is contained in:
commit
f2b170a736
@ -59,4 +59,8 @@ class GildedRose {
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
public void updateQuantities(){
|
||||
|
||||
}
|
||||
}
|
||||
|
||||
@ -6,12 +6,5 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
|
||||
|
||||
class GildedRoseTest {
|
||||
|
||||
@Test
|
||||
void foo() {
|
||||
Item[] items = new Item[] { new Item("foo", 0, 0) };
|
||||
GildedRose app = new GildedRose(items);
|
||||
app.updateQuality();
|
||||
assertEquals("fixme", app.items[0].name);
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
15
Java/src/test/java/com/gildedrose/ItemTest.java
Normal file
15
Java/src/test/java/com/gildedrose/ItemTest.java
Normal file
@ -0,0 +1,15 @@
|
||||
package com.gildedrose;
|
||||
|
||||
import org.junit.jupiter.api.Test;
|
||||
|
||||
import static org.junit.jupiter.api.Assertions.assertEquals;
|
||||
|
||||
class ItemTest{
|
||||
|
||||
@Test
|
||||
void toImplement() {
|
||||
//todo testing the class
|
||||
assertEquals(true,true);
|
||||
}
|
||||
|
||||
}
|
||||
159
Java/src/test/java/com/gildedrose/UpdateQualityTest.java
Normal file
159
Java/src/test/java/com/gildedrose/UpdateQualityTest.java
Normal file
@ -0,0 +1,159 @@
|
||||
package com.gildedrose;
|
||||
|
||||
import org.junit.jupiter.api.Test;
|
||||
|
||||
import static org.junit.jupiter.api.Assertions.assertEquals;
|
||||
|
||||
/**
|
||||
* Set up basic Testing for the initial features and guidelines
|
||||
*/
|
||||
class UpdateQualityTest {
|
||||
|
||||
@Test
|
||||
void itemDaysLeftDecreasesByONeAtEachIteration() {
|
||||
Item[] items = new Item[]{new Item("Elixir of the Mongoose", 5, 7)};
|
||||
GildedRose app = new GildedRose(items);
|
||||
app.updateQuality();
|
||||
assertEquals("Elixir of the Mongoose", app.items[0].name);
|
||||
System.out.println("Quality: " + app.items[0].sellIn);
|
||||
assertEquals(4, app.items[0].sellIn);
|
||||
app.updateQuality();
|
||||
assertEquals(3, app.items[0].sellIn);
|
||||
}
|
||||
|
||||
@Test
|
||||
void itemQualityLeftDecreasesByOneAtEachIteration() {
|
||||
Item[] items = new Item[]{new Item("Elixir of the Mongoose", 5, 7)};
|
||||
GildedRose app = new GildedRose(items);
|
||||
app.updateQuality();
|
||||
assertEquals("Elixir of the Mongoose", app.items[0].name);
|
||||
System.out.println("Quality: " + app.items[0].quality);
|
||||
assertEquals(6, app.items[0].quality);
|
||||
app.updateQuality();
|
||||
assertEquals(5, app.items[0].quality);
|
||||
}
|
||||
|
||||
@Test
|
||||
void qualityDegradationSpeedAfterOneIterationWhenOutdated() {
|
||||
System.out.println("Once the sell by date has passed, Quality degrades twice as fast");
|
||||
Item[] items = new Item[]{new Item("+5 Dexterity Vest", 0, 20)};
|
||||
GildedRose app = new GildedRose(items);
|
||||
app.updateQuality();
|
||||
System.out.println("Quality: " + app.items[0].quality);
|
||||
assertEquals(18, app.items[0].quality);
|
||||
assertEquals("+5 Dexterity Vest", app.items[0].name);
|
||||
}
|
||||
|
||||
@Test
|
||||
void qualityIteNeverNegatif() {
|
||||
System.out.println("The Quality of an item is never negative");
|
||||
Item[] items = new Item[]{new Item("+5 Dexterity Vest", 10, 1)};
|
||||
GildedRose app = new GildedRose(items);
|
||||
app.updateQuality();
|
||||
app.updateQuality();
|
||||
System.out.println("Quality: " + app.items[0].quality);
|
||||
assertEquals(0, app.items[0].quality);
|
||||
assertEquals("+5 Dexterity Vest", app.items[0].name);
|
||||
}
|
||||
|
||||
@Test
|
||||
void agedBrieQualityIncreaseWthIteration() {
|
||||
System.out.println("\"Aged Brie\" actually increases in Quality the older it gets");
|
||||
Item[] items = new Item[]{new Item("Aged Brie", 5, 0)};
|
||||
GildedRose app = new GildedRose(items);
|
||||
app.updateQuality();
|
||||
app.updateQuality();
|
||||
assertEquals("Aged Brie", app.items[0].name);
|
||||
System.out.println("Quality: " + app.items[0].quality);
|
||||
assertEquals(2, app.items[0].quality);
|
||||
app.updateQuality();
|
||||
assertEquals(3, app.items[0].quality);
|
||||
}
|
||||
|
||||
@Test
|
||||
void qualityItemNoMore50() {
|
||||
System.out.println("The Quality of an item is never more than 50");
|
||||
Item[] items = new Item[]{new Item("Aged Brie", 10, 49)};
|
||||
GildedRose app = new GildedRose(items);
|
||||
assertEquals("Aged Brie", app.items[0].name);
|
||||
app.updateQuality();
|
||||
System.out.println("Quality: " + app.items[0].quality);
|
||||
assertEquals(50, app.items[0].quality);
|
||||
app.updateQuality();
|
||||
assertEquals(50, app.items[0].quality);
|
||||
|
||||
}
|
||||
|
||||
@Test
|
||||
void qualitySulfurasItemNoMore80() {
|
||||
System.out.println("The \"Sulfuras\"'s Quality is never more than 80");
|
||||
Item[] items = new Item[]{new Item("Sulfuras, Hand of Ragnaros", 5, 80)};
|
||||
GildedRose app = new GildedRose(items);
|
||||
assertEquals("Sulfuras, Hand of Ragnaros", app.items[0].name);
|
||||
app.updateQuality();
|
||||
System.out.println("Quality: " + app.items[0].quality);
|
||||
assertEquals(80, app.items[0].quality);
|
||||
app.updateQuality();
|
||||
assertEquals(80, app.items[0].quality);
|
||||
}
|
||||
|
||||
|
||||
@Test
|
||||
void itemSulfurasNotDecreasedQuality() {
|
||||
System.out.println("\"Sulfuras\", being a legendary item, never decreases in Quality");
|
||||
Item[] items = new Item[]{new Item("Sulfuras, Hand of Ragnaros", 5, 79)};
|
||||
GildedRose app = new GildedRose(items);
|
||||
assertEquals("Sulfuras, Hand of Ragnaros", app.items[0].name);
|
||||
for (int i = 0; i < 10; i++) {
|
||||
app.updateQuality();
|
||||
}
|
||||
assertEquals(79, app.items[0].quality);
|
||||
}
|
||||
|
||||
@Test
|
||||
void itemBackstageQualityIncreasesByTwoWhenTenDaysOrLess() {
|
||||
System.out.println(" Quality increases by 2 when there are 10 days or less");
|
||||
Item[] items = new Item[]{
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 10, 0),
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 9, 0),
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 8, 0)
|
||||
};
|
||||
GildedRose app = new GildedRose(items);
|
||||
app.updateQuality();
|
||||
for (int i = 0; i < 2; i++) {
|
||||
assertEquals(2, app.items[i].quality);
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void itemBackstageQualityIncreasesByThreeWhenFiveDaysOrLess() {
|
||||
System.out.println("Quality increases by 3 when there are 5 days or less");
|
||||
Item[] items = new Item[]{
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 5, 3),
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 4, 3),
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 2, 3)
|
||||
};
|
||||
GildedRose app = new GildedRose(items);
|
||||
app.updateQuality();
|
||||
for (int i = 0; i < 2; i++) {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Testing for "Conjured" items
|
||||
*/
|
||||
|
||||
|
||||
@Test
|
||||
void itemConjuredQualityTwiceAsFastAsNormalItems() {
|
||||
System.out.println("\"Conjured\" items degrade in Quality twice as fast as normal items");
|
||||
Item[] items = new Item[]{
|
||||
new Item("Conjured Mana Cake", 3, 6)};
|
||||
GildedRose app = new GildedRose(items);
|
||||
app.updateQuality();
|
||||
assertEquals(4, app.items[0].quality);
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
|
||||
64
Java/src/test/java/com/gildedrose/updateQuantitiesTest.java
Normal file
64
Java/src/test/java/com/gildedrose/updateQuantitiesTest.java
Normal file
@ -0,0 +1,64 @@
|
||||
package com.gildedrose;
|
||||
|
||||
import org.junit.jupiter.api.Test;
|
||||
|
||||
import static org.junit.jupiter.api.Assertions.assertEquals;
|
||||
|
||||
|
||||
/**
|
||||
* Testing for Selling items
|
||||
*/
|
||||
|
||||
class updateQuantitiesTest {
|
||||
@Test
|
||||
void itemsSoldAfterConcert() {
|
||||
Item[] items = new Item[] {
|
||||
new Item("+5 Dexterity Vest", 10, 20), //
|
||||
new Item("Aged Brie", 2, 0), //
|
||||
new Item("Elixir of the Mongoose", 5, 7), //
|
||||
new Item("Sulfuras, Hand of Ragnaros", 0, 80), //
|
||||
new Item("Sulfuras, Hand of Ragnaros", -1, 80),
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 15, 20),
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 10, 49),
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 5, 49)
|
||||
};
|
||||
GildedRose app = new GildedRose(items);
|
||||
app.updateQuantities();
|
||||
// assertEquals(, app.items.length);
|
||||
}
|
||||
|
||||
@Test
|
||||
void itemBackstageQualityDropsToZeroAfterTheConcert() {
|
||||
System.out.println("Quality drops to 0 after the concert");
|
||||
Item[] items = new Item[]{
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 10, 2),
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 9, 3),
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 8, 7)
|
||||
};
|
||||
GildedRose app = new GildedRose(items);
|
||||
app.updateQuantities();
|
||||
for ( Item el: items) {
|
||||
assertEquals(0, el.quality);
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void itemSulfurasNotSold() {
|
||||
System.out.println("\"Sulfuras\", being a legendary item, never has to be sold");
|
||||
Item[] items = new Item[] {
|
||||
new Item("+5 Dexterity Vest", 10, 20), //
|
||||
new Item("Aged Brie", 2, 0), //
|
||||
new Item("Elixir of the Mongoose", 5, 7), //
|
||||
new Item("Sulfuras, Hand of Ragnaros", 0, 80), //
|
||||
new Item("Sulfuras, Hand of Ragnaros", -1, 80),
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 15, 20),
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 10, 49),
|
||||
new Item("Backstage passes to a TAFKAL80ETC concert", 5, 49)
|
||||
};
|
||||
GildedRose app = new GildedRose(items);
|
||||
app.updateQuantities();
|
||||
assertEquals(2, app.items.length);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user