From f576dd8f49e8cffd14993d3b0557cc145d76f008 Mon Sep 17 00:00:00 2001 From: lekshmysasidhar Date: Fri, 31 Mar 2023 10:39:05 +0200 Subject: [PATCH] Code Refactoring :Separated expired item quality check based on item type to improve readability. --- Java/src/main/java/com/gildedrose/GildedRose.java | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/Java/src/main/java/com/gildedrose/GildedRose.java b/Java/src/main/java/com/gildedrose/GildedRose.java index 224c5e7a..3d2e3873 100644 --- a/Java/src/main/java/com/gildedrose/GildedRose.java +++ b/Java/src/main/java/com/gildedrose/GildedRose.java @@ -60,18 +60,25 @@ class GildedRose { if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (item.quality > 0) { if (!item.name.equals("Sulfuras, Hand of Ragnaros")) { - item.quality = item.quality - 1; + updateQualityForExpiredItemNormal(item); } } } else { - item.quality = item.quality - item.quality; + updateQualityForExpiredItemBackstagePasses(item); } } else { addQualityWhenWithInLimit(item); } } } - + + private void updateQualityForExpiredItemBackstagePasses(Item item) { + item.quality = 0; + } + + private void updateQualityForExpiredItemNormal(Item item) { + item.quality--; + } private void updateSellInDays(Item item) { item.sellIn--;