OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 06:21:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

added AgedBrieQualityRule

Browse Source
This commit is contained in:
Konstantin Pavlov 2019-06-30 06:34:30 +02:00
parent c297cc00cc
commit f60b800cd8
2 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -1,5 +1,6 @@
package com.gildedrose; package com.gildedrose;
import com.gildedrose.rules.AgedBrieQualityRule;
import com.gildedrose.rules.QualityRule; import com.gildedrose.rules.QualityRule;
import com.gildedrose.rules.SulfurasQualityRule; import com.gildedrose.rules.SulfurasQualityRule;
import lombok.val; import lombok.val;
@ -11,6 +12,7 @@ class GildedRose {
private final List<QualityRule> rules = List.of( private final List<QualityRule> rules = List.of(
new SulfurasQualityRule(), new SulfurasQualityRule(),
new AgedBrieQualityRule(),
new QualityRule() new QualityRule()
); );
@ -38,6 +40,7 @@ class GildedRose {
}, },
(a, b) -> b).getQuality(); (a, b) -> b).getQuality();
/*
if (!item.name.equals("Aged Brie") if (!item.name.equals("Aged Brie")
&& !item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { && !item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality > 0) { if (item.quality > 0) {
@ -64,10 +67,11 @@ class GildedRose {
} }
} }
} }
*/
val newSellIn = calculateSellIn(item.name, item.sellIn); val newSellIn = calculateSellIn(item.name, item.sellIn);
if (newSellIn < 0) { /* if (newSellIn < 0) {
if (!item.name.equals("Aged Brie")) { if (!item.name.equals("Aged Brie")) {
if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality > 0) { if (item.quality > 0) {
@ -83,7 +87,7 @@ class GildedRose {
item.quality = item.quality + 1; item.quality = item.quality + 1;
} }
} }
} }*/
item.quality = newQuality; item.quality = newQuality;
item.sellIn = newSellIn; item.sellIn = newSellIn;

16
Java/src/main/java/com/gildedrose/rules/AgedBrieQualityRule.java Normal file
View File

@ -0,0 +1,16 @@
package com.gildedrose.rules;
import static java.lang.Integer.min;
public class AgedBrieQualityRule extends QualityRule {
@Override
public boolean shouldApply(String itemName) {
return "Aged Brie".equals(itemName);
}
@Override
public Result calculateQuality(int oldQuality) {
return new Result(min(oldQuality + 1, 50), true);
}
}