From f68dbcfdcfa6e85b08ec7e7c99e0dc1cf915105f Mon Sep 17 00:00:00 2001
From: jns9j04 <joris.nens@colruytgroup.com>
Date: Wed, 26 Mar 2025 09:04:18 +0100
Subject: [PATCH] upgrade dependencies, run cucumber as unit test

---
 Java-Cucumber/build.gradle                                | 8 +++++---
 .../src/test/java/com/gildedrose/RunCucumberTest.java     | 3 ++-
 .../src/test/resources/com/gildedrose/GildedRose.feature  | 2 +-
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/Java-Cucumber/build.gradle b/Java-Cucumber/build.gradle
index a21a1631..b6bbc0ae 100644
--- a/Java-Cucumber/build.gradle
+++ b/Java-Cucumber/build.gradle
@@ -10,9 +10,11 @@ targetCompatibility = '21'
 
 dependencies {
     implementation 'org.codehaus.groovy:groovy:3.0.8'
-    testImplementation 'io.cucumber:cucumber-java:6.10.4'
-    testImplementation 'io.cucumber:cucumber-junit:6.10.4'
-    testImplementation 'junit:junit:4.13.2'
+    testImplementation 'io.cucumber:cucumber-java:7.21.1'
+    testImplementation 'io.cucumber:cucumber-junit:7.21.1'
+    testImplementation 'org.junit.jupiter:junit-jupiter-api:5.9.3'
+    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.9.3'
+    testImplementation 'org.junit.vintage:junit-vintage-engine:5.9.3'
 }
 
 configurations {
diff --git a/Java-Cucumber/src/test/java/com/gildedrose/RunCucumberTest.java b/Java-Cucumber/src/test/java/com/gildedrose/RunCucumberTest.java
index e955f030..a13510b0 100644
--- a/Java-Cucumber/src/test/java/com/gildedrose/RunCucumberTest.java
+++ b/Java-Cucumber/src/test/java/com/gildedrose/RunCucumberTest.java
@@ -5,7 +5,8 @@ import io.cucumber.junit.CucumberOptions;
 import org.junit.runner.RunWith;
 
 @RunWith(Cucumber.class)
-@CucumberOptions()
+@CucumberOptions(plugin = {"pretty", "html:target/cucumber-report.html"},
+        features = {"src/test/resources"})
 public class RunCucumberTest {
 }
 
diff --git a/Java-Cucumber/src/test/resources/com/gildedrose/GildedRose.feature b/Java-Cucumber/src/test/resources/com/gildedrose/GildedRose.feature
index 72f0910c..30e5415d 100644
--- a/Java-Cucumber/src/test/resources/com/gildedrose/GildedRose.feature
+++ b/Java-Cucumber/src/test/resources/com/gildedrose/GildedRose.feature
@@ -2,6 +2,6 @@ Feature: Gilded Rose quality
   I want to know if the quality is updated properly
 
   Scenario: Checking foo
-    Given The item as "fixme"
+    Given The item as "foo"
     When I update the quality
     Then I should get item as "foo"