OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 22:41:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

added MAX_ITEM_QUALITY in constants file and referred it

Browse Source
This commit is contained in:
Chamoda Ranasinghe 2024-01-16 02:30:10 +07:00
parent e44c0a1d18
commit f6a3a6d718
No known key found for this signature in database
GPG Key ID: DE81C3C335B7CED3
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
TypeScript/app/constants.ts
View File

@ -1,4 +1,3 @@
/* /*
A const to hold the names of the items A const to hold the names of the items
*/ */
@ -8,4 +7,6 @@ const ItemNames = {
SULFURAS: "Sulfuras, Hand of Ragnaros", SULFURAS: "Sulfuras, Hand of Ragnaros",
}; };
export { ItemNames }; const MAX_ITEM_QUALITY = 50;
export { ItemNames, MAX_ITEM_QUALITY };

11
TypeScript/app/gilded-rose.ts
View File

@ -1,5 +1,4 @@
import { ItemNames } from "./constants"; import { ItemNames, MAX_ITEM_QUALITY } from "./constants";
export class Item { export class Item {
name: string; name: string;
@ -32,16 +31,16 @@ export class GildedRose {
} }
} }
} else { } else {
if (item.quality < 50) { if (item.quality < MAX_ITEM_QUALITY) {
item.quality = item.quality + 1; item.quality = item.quality + 1;
if (item.name == ItemNames.BACKSTAGE_PASSES) { if (item.name == ItemNames.BACKSTAGE_PASSES) {
if (item.sellIn < 11) { if (item.sellIn < 11) {
if (item.quality < 50) { if (item.quality < MAX_ITEM_QUALITY) {
item.quality = item.quality + 1; item.quality = item.quality + 1;
} }
} }
if (item.sellIn < 6) { if (item.sellIn < 6) {
if (item.quality < 50) { if (item.quality < MAX_ITEM_QUALITY) {
item.quality = item.quality + 1; item.quality = item.quality + 1;
} }
} }
@ -63,7 +62,7 @@ export class GildedRose {
item.quality = item.quality - item.quality; item.quality = item.quality - item.quality;
} }
} else { } else {
if (item.quality < 50) { if (item.quality < MAX_ITEM_QUALITY) {
item.quality = item.quality + 1; item.quality = item.quality + 1;
} }
} }