From ff06861ab76bef5010a2b55ee65ca0f3854a476b Mon Sep 17 00:00:00 2001 From: Michel Grootjans Date: Mon, 30 Dec 2019 13:08:06 +0100 Subject: [PATCH] added (no) for negative path in if-statements --- plantuml/gilded-rose.puml | 15 ++++++++++++++- plantuml/history/02_sell-by-passed.puml | 2 +- plantuml/history/03_quality-never-negative.puml | 3 +++ plantuml/history/04_aged-brie.puml | 3 +++ plantuml/history/05_quality-max-50.puml | 4 ++++ plantuml/history/06_sulfuras.puml | 8 ++++++++ plantuml/history/07_backstage-passes.puml | 13 +++++++++++++ 7 files changed, 46 insertions(+), 2 deletions(-) diff --git a/plantuml/gilded-rose.puml b/plantuml/gilded-rose.puml index 08b5d7a1..7c463967 100644 --- a/plantuml/gilded-rose.puml +++ b/plantuml/gilded-rose.puml @@ -10,7 +10,9 @@ if (not "Aged Brie" and not "Backstage passes to a TAFKAL80ETC concert") then (y if (quality > 0) then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes) -lower quality with 1 + else (no) endif + else (no) endif else (no) if (quality < 50) then (yes) @@ -19,19 +21,26 @@ else (no) if (sell in < 11) then (yes) if (quality < 50) then (yes) -increase quality with 1 + else (no) endif + else (no) endif if (sell in < 6) then (yes) if (quality < 50) then (yes) -increase quality with 1 + else (no) endif + else (no) endif + else (no) endif + else (no) endif endif if (not "Sulfuras, Hand of Ragnaros") then (yes) - -lower quality with 1 + -lower sell in with 1 +else (no) endif if (sell in < 0) then (yes) @@ -40,7 +49,9 @@ if (sell in < 0) then (yes) if (quality > 0) then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes) -lower quality with 1 + else (no) endif + else (no) endif else (no) -lower quality with quality @@ -48,8 +59,10 @@ if (sell in < 0) then (yes) else (no) if (quality < 50) then (yes) -increase quality with 1 + else (no) endif endif +else (no) endif stop diff --git a/plantuml/history/02_sell-by-passed.puml b/plantuml/history/02_sell-by-passed.puml index 0c763688..730f7e5f 100644 --- a/plantuml/history/02_sell-by-passed.puml +++ b/plantuml/history/02_sell-by-passed.puml @@ -7,11 +7,11 @@ note left end note -lower quality with 1 - -lower sell in with 1 if (sell in < 0) then (yes) -lower quality with 1 +else (no) endif stop diff --git a/plantuml/history/03_quality-never-negative.puml b/plantuml/history/03_quality-never-negative.puml index df7859ac..18cee44a 100644 --- a/plantuml/history/03_quality-never-negative.puml +++ b/plantuml/history/03_quality-never-negative.puml @@ -8,6 +8,7 @@ end note if (quality > 0) then (yes) -lower quality with 1 +else (no) endif -lower sell in with 1 @@ -15,7 +16,9 @@ endif if (sell in < 0) then (yes) if (quality > 0) then (yes) -lower quality with 1 + else (no) endif +else (no) endif stop diff --git a/plantuml/history/04_aged-brie.puml b/plantuml/history/04_aged-brie.puml index 3a484fc4..ac495227 100644 --- a/plantuml/history/04_aged-brie.puml +++ b/plantuml/history/04_aged-brie.puml @@ -9,6 +9,7 @@ end note if (not "Aged Brie") then (yes) if (quality > 0) then (yes) -lower quality with 1 + else (no) endif else (no) -increase quality with 1 @@ -20,10 +21,12 @@ if (sell in < 0) then (yes) if (not "Aged Brie") then (yes) if (quality > 0) then (yes) -lower quality with 1 + else (no) endif else (no) -increase quality with 1 endif +else (no) endif stop diff --git a/plantuml/history/05_quality-max-50.puml b/plantuml/history/05_quality-max-50.puml index 5200ca72..6991f51b 100644 --- a/plantuml/history/05_quality-max-50.puml +++ b/plantuml/history/05_quality-max-50.puml @@ -9,10 +9,12 @@ end note if (not "Aged Brie") then (yes) if (quality > 0) then (yes) -lower quality with 1 + else (no) endif else (no) if (quality < 50) then (yes) -increase quality with 1 + else (no) endif endif @@ -22,10 +24,12 @@ if (sell in < 0) then (yes) if (not "Aged Brie") then (yes) if (quality > 0) then (yes) -lower quality with 1 + else (no) endif else (no) if (quality < 50) then (yes) -increase quality with 1 + else (no) endif endif endif diff --git a/plantuml/history/06_sulfuras.puml b/plantuml/history/06_sulfuras.puml index 0c7cf0bf..1690228c 100644 --- a/plantuml/history/06_sulfuras.puml +++ b/plantuml/history/06_sulfuras.puml @@ -10,16 +10,20 @@ if (not "Aged Brie") then (yes) if (quality > 0) then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes) -lower quality with 1 + else (no) endif + else (no) endif else (no) if (quality < 50) then (yes) -increase quality with 1 + else (no) endif endif if (not "Sulfuras, Hand of Ragnaros") then (yes) -lower sell in with 1 +else (no) endif if (sell in < 0) then (yes) @@ -27,13 +31,17 @@ if (sell in < 0) then (yes) if (quality > 0) then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes) -lower quality with 1 + else (no) endif + else (no) endif else (no) if (quality < 50) then (yes) -increase quality with 1 + else (no) endif endif +else (no) endif stop diff --git a/plantuml/history/07_backstage-passes.puml b/plantuml/history/07_backstage-passes.puml index 53a92fd8..7c463967 100644 --- a/plantuml/history/07_backstage-passes.puml +++ b/plantuml/history/07_backstage-passes.puml @@ -10,7 +10,9 @@ if (not "Aged Brie" and not "Backstage passes to a TAFKAL80ETC concert") then (y if (quality > 0) then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes) -lower quality with 1 + else (no) endif + else (no) endif else (no) if (quality < 50) then (yes) @@ -19,19 +21,26 @@ else (no) if (sell in < 11) then (yes) if (quality < 50) then (yes) -increase quality with 1 + else (no) endif + else (no) endif if (sell in < 6) then (yes) if (quality < 50) then (yes) -increase quality with 1 + else (no) endif + else (no) endif + else (no) endif + else (no) endif endif if (not "Sulfuras, Hand of Ragnaros") then (yes) -lower sell in with 1 +else (no) endif if (sell in < 0) then (yes) @@ -40,7 +49,9 @@ if (sell in < 0) then (yes) if (quality > 0) then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes) -lower quality with 1 + else (no) endif + else (no) endif else (no) -lower quality with quality @@ -48,8 +59,10 @@ if (sell in < 0) then (yes) else (no) if (quality < 50) then (yes) -increase quality with 1 + else (no) endif endif +else (no) endif stop