OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
535 Commits 1 Branch 0 Tags 39 MiB
75fa4869c0
Commit Graph

535 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
ollie beney
75fa4869c0 found and fixed bug where quality could go above 50 and below 0 when change increment was greater than one 2020-11-05 17:03:15 +00:00
ollie beney
24ebe0b7dd created boolean methods for brie and backstage, implemented them in a case statement 2020-11-05 16:24:53 +00:00
ollie beney
e2673f0734 extracted all product types into their own methods and tested 2020-11-05 16:14:49 +00:00
ollie beney
c0ae6e9988 extracted quality updates for backstage passes 2020-11-05 15:16:09 +00:00
ollie beney
146f686d14 removed duplicated conditionals 2020-11-05 14:14:54 +00:00
ollie beney
3773a972aa actually fixed special item this time, feature tests also fixed 2020-11-05 12:49:20 +00:00
ollie beney
89fb0d8689 corrected special_item method and added further test for this. 2020-11-05 12:38:18 +00:00
ollie beney
58be55719a extracted #special_item? method and implemented in update quality section 2020-11-05 12:30:32 +00:00
ollie beney
7a8792f64f got taken on to zoom call with peer group, unsure whats changed but rspec still passes 2020-11-04 18:02:22 +00:00
ollie beney
6c85b130e5 changed if statement to inline conditional 2020-11-04 17:10:04 +00:00
ollie beney
0ae0723f57 changed part of method that changes backstage pass quality to zero to a more logical method 2020-11-04 17:07:04 +00:00
ollie beney
626eab9e10 updated code to use update_normal_quality method 2020-11-04 16:58:25 +00:00
ollie beney
2431b8b11e replaced instances of item != sulfuras with sulfuras? method 2020-11-04 16:57:36 +00:00
ollie beney
70040c5144 updated spelling of sulfuras 2020-11-04 16:55:20 +00:00
ollie beney
bbe5395911 added method to check if an item is selfarus 2020-11-04 16:51:20 +00:00
ollie beney
27860ced34 update_normal_item method updates items without quality allowances if quality > 0 2020-11-04 16:39:36 +00:00
ollie beney
2b410aa50b refactor backstage path to use regex, this allows other backstage items to work provided backstage is in their name 2020-11-04 15:28:47 +00:00
ollie beney
c940184607 add tests for backstage items 2020-11-04 15:15:36 +00:00
ollie beney
f7556aecc0 add tests for sulfuras input 2020-11-04 15:04:25 +00:00
ollie beney
39ff5fee08 test existing behaviour for aged brie 2020-11-04 14:57:13 +00:00
ollie beney
d8426bd884 testing to see if item value drops below 0 2020-11-04 14:36:00 +00:00
ollie beney
fb4d5aad4d basic test for ordinary item, made update_quality method into an instance method 2020-11-04 14:32:23 +00:00
ollie beney
06c28be5b1 added rubocop 2020-11-04 13:56:42 +00:00
ollie beney
5437b449e8 removed files I'm not using 2020-11-04 13:43:50 +00:00
Emily Bache
e2c5826e71
Merge pull request #184 from ag4ta/change-line-separator 
Unify line separator in ruby example
 2020-09-27 08:50:29 +02:00
Agata Werszler
50daf3f025 Change line separator from CRLF to LF 2020-09-25 16:45:40 +02:00
Emily Bache
5ed37f4be5
Merge pull request #182 from mebusw/patch-2 
Update some words with explanation for paronomasia
 2020-09-25 08:33:11 +02:00
Jacky Shen
b713f7370d
Update GildedRoseRequirements_zh.txt 2020-09-25 13:05:39 +08:00
Emily Bache
a8dd468300
Merge pull request #179 from emilybache/dependabot/composer/php/symfony/http-kernel-5.1.5 
Bump symfony/http-kernel from 5.0.8 to 5.1.5 in /php
 2020-09-08 14:51:16 +00:00
Emily Bache
b4a6bc2445
Merge pull request #178 from emilybache/dependabot/npm_and_yarn/js-jest/yargs-parser-13.1.2 
Bump yargs-parser from 13.1.1 to 13.1.2 in /js-jest
 2020-09-08 14:47:05 +00:00
dependabot[bot]
9c42d32cf4
Bump symfony/http-kernel from 5.0.8 to 5.1.5 in /php 
Bumps [symfony/http-kernel](https://github.com/symfony/http-kernel) from 5.0.8 to 5.1.5.
- [Release notes](https://github.com/symfony/http-kernel/releases)
- [Changelog](https://github.com/symfony/http-kernel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/symfony/http-kernel/compare/v5.0.8...v5.1.5)

Signed-off-by: dependabot[bot] <support@github.com>
 2020-09-08 13:27:13 +00:00
dependabot[bot]
e5d807ebeb
Bump yargs-parser from 13.1.1 to 13.1.2 in /js-jest 
Bumps [yargs-parser](https://github.com/yargs/yargs-parser) from 13.1.1 to 13.1.2.
- [Release notes](https://github.com/yargs/yargs-parser/releases)
- [Changelog](https://github.com/yargs/yargs-parser/blob/master/docs/CHANGELOG-full.md)
- [Commits](https://github.com/yargs/yargs-parser/commits)

Signed-off-by: dependabot[bot] <support@github.com>
 2020-09-08 13:26:39 +00:00
Emily Bache
99703481d7
Merge pull request #177 from emilybache/dependabot/npm_and_yarn/js-jest/handlebars-4.7.6 
Bump handlebars from 4.4.3 to 4.7.6 in /js-jest
 2020-09-08 11:34:41 +00:00
dependabot[bot]
8140c13575
Bump handlebars from 4.4.3 to 4.7.6 in /js-jest 
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.4.3 to 4.7.6.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.4.3...v4.7.6)

Signed-off-by: dependabot[bot] <support@github.com>
 2020-09-07 14:24:39 +00:00
Emily Bache
1c94a43a2d
Merge pull request #176 from olivierperez/fix/adjust-fr-requirements 
Adjust a bit French requirements
 2020-09-07 13:46:10 +00:00
Olivier PEREZ
e5c0d2653c Adjust a bit French description 2020-09-06 16:00:37 +02:00
Emily Bache
94b6e7a1e8
Merge pull request #174 from wpanas/upgrade_kotlin 
Upgrade kotlin to 1.4.0, junit to 5.6.2 & gradle to 6.6
 2020-08-21 11:12:02 +00:00
wpanas
cce7b6381f Upgrade kotlin to 1.4.0, junit to 5.6.2 & gradle to 6.6 2020-08-20 14:44:45 +02:00
Emily Bache
cd4e977616
Merge pull request #171 from nihonbuson/master 
Create GildedRoseRequirements_jp.md
 2020-08-17 05:50:10 +00:00
nihonbuson
30d1966bbe
Update GildedRoseRequirements_jp.md 
改行を変更した。
 2020-08-17 10:47:34 +09:00
nihonbuson
936c96524b
Create GildedRoseRequirements_jp.md 
日本語訳を作成
 2020-08-17 10:46:24 +09:00
Emily Bache
28443f97b2
Merge pull request #167 from mergermarket/ts-texttest 
Create texttest settings for TypeScript version
 2020-07-27 10:32:26 +02:00
Emily Bache
ef5d1ffb9f
Merge pull request #166 from Pen-y-Fan/php72 
Php72
 2020-07-27 10:29:35 +02:00
Emily Bache
ce38179dbd
Merge pull request #165 from rrokkam/rust-update 
Update Rust to 2018 edition
 2020-07-27 10:26:09 +02:00
Emily Bache
185fa40b80
Merge pull request #164 from emilybache/dependabot/npm_and_yarn/js-jest/lodash-4.17.19 
Bump lodash from 4.17.15 to 4.17.19 in /js-jest
 2020-07-27 10:24:38 +02:00
osh
64d521d9a3 Create texttest settings for TypeScript version 2020-07-24 21:45:33 +01:00
Pen-y-Fan
b4a02d3f5e Updated PHP version for PHP7.2+ 
Removed PHP5 (no longer supported)
Renamed PHP7 to PHP - consistent with other kata
Added the same helpers as other PHP Kata
Updated the code to PHP7.2+ standard
Didn't change GildedRose updateQuality method
Updated GildedRoseTest (still failing)
Added ApprovalTest (passing)
- same text file as texttests / ThirtyDays / stdout.gr (only renamed).
 2020-07-23 22:49:59 +01:00
Pen-y-Fan
ed7a787e4f Updated PHP version for PHP7.2+ 
Removed PHP5 (no longer supported)
Renamed PHP7 to PHP - consistent with other kata
Added the same helpers as other PHP Kata
Updated the code to PHP7.2+ standard
Didn't change GildedRose updateQuality method
Updated GildedRoseTest (still failing)
Added ApprovalTest (passing)
- same text file as texttests / ThirtyDays / stdout.gr (only renamed).
 2020-07-23 22:47:36 +01:00
rrokkam
45e53e823b Bump to 2018 edition 2020-07-19 13:51:32 -07:00
rrokkam
d897d295b7 Update Cargo.toml; bump version number 2020-07-19 13:51:27 -07:00