Commit Graph

18 Commits

Author SHA1 Message Date
Sarah Ashri
9293c86c66 DailyUpdaterFactory reuse existing updaters instead of creating new ones every time. 2024-03-15 09:03:42 +10:00
Sarah Ashri
7fbb554030 Extract logic to create Updater into DailyUpdaterFactory and some minor refactoring in DailyUpdater.cs 2024-03-14 15:43:31 +10:00
Sarah Ashri
a585b181da Move DailyUpdate of each type to DailyUpdaterHierarchy and add a simple factory method to get the appropriate updater to use. 2024-03-14 14:27:42 +10:00
Sarah Ashri
0e52fc7c4b Finishes separating DailyUpdate processing according to type. Still in the same method. 2024-03-13 14:28:27 +10:00
Sarah Ashri
c7eafcaeec separate processing of different types 2024-03-13 14:12:21 +10:00
Sarah Ashri
3d28a742b5 DailyItemUpdate: extract increase/decrease quality into a separate method 2024-03-13 14:04:40 +10:00
Sarah Ashri
c85ce91a08 Add RefactoringDiary to document my refactoring journey 2024-03-13 11:55:42 +10:00
Sarah Ashri
b5f5867081 DailyItemUpdate: seperate handling for different item types 2024-03-13 11:40:26 +10:00
Sarah Ashri
03032c91c2 extracted LegendaryItems processing from if statements in DailyItemUpdate
LegendayItems don't change and therefore, can return immediately
2024-03-13 10:20:55 +10:00
Sarah Ashri
dd66f563e9 Extract item types condition from the DailyItemUpdate method and refactored related tests
* in tests:
   - renamed tests to use the different item types
   - Added more test cases to support the fixed functionality of better types' recognition.

* reran the 30 days texttest to verify the changes until now
2024-03-13 10:17:00 +10:00
Sarah Ashri
165322b336 Add constants for Quality min/max 2024-03-13 09:49:27 +10:00
Sarah Ashri
a69f02d975 ported previous refactoring to csharpcore project
Made the previous ones in csharp instead by mistake
2024-03-13 09:33:07 +10:00
Daniel Petrov
03a9d294d2 Update csharp core nunit project to latest SDK and libs 2024-02-05 12:37:27 +01:00
Maxim Stomphorst
ad56fa1ce0 cleanup 2023-08-30 21:02:31 +02:00
emily
6a91a10bfa update to latest .net version 2023-08-29 11:36:23 +02:00
Samuel Dufour
4746d897f5 Remove ApprovalTest and add TexttestFixture 2021-12-27 23:25:40 +01:00
Kyle McMaster
7d795a5d67 chore(csharp-core): update packages and framework to .net 6.0 2021-12-03 22:29:48 -08:00
Will Verland
85a1611787 Fix misspelling of Guilded => Gilded for PR #252 2021-07-23 11:30:53 +12:00