Sarah Ashri
bdf20e735c
Add new Conjured Items requirement and related tests
...
Also added some final notes on this solution and suggestions for further changes if we can change Item
2024-03-15 14:36:44 +10:00
Sarah Ashri
ed1ef9153b
Merge branch 'csharpcore-refactoring-2024' of https://github.com/Sarah-A/GildedRose-Refactoring-Kata into csharpcore-refactoring-2024
2024-03-15 14:19:06 +10:00
Sarah Ashri
0953f31cb9
Refactored ApprovalTest
...
This is preparation for adding the conjured items
- Updated the created Conjured item to allow testing with the new requirement
- Changed to work with local expectedOutput file
2024-03-15 14:17:10 +10:00
Sarah Ashri
cb822ff94e
Fixed ApprovalTest to work with local expectedOutput file
...
This is preparation for adding the conjured items
2024-03-15 14:11:24 +10:00
Sarah Ashri
d076fc9ba4
Add ItemBuilders hierarchy to enforce building valid items
...
Also updated unit tests:
- Added unit tests for the new ItemBuilders classes
- Refactored existing tests to use the new builders
2024-03-15 11:46:55 +10:00
Sarah Ashri
eb741a95c5
Seperated the derived DailyUpdater classes into their own files
2024-03-15 11:23:20 +10:00
Sarah Ashri
5e5d6e9fa7
Extract item types and quality into their own classes to allow reuse
2024-03-15 11:18:11 +10:00
Sarah Ashri
9293c86c66
DailyUpdaterFactory reuse existing updaters instead of creating new ones every time.
2024-03-15 09:03:42 +10:00
Sarah Ashri
7fbb554030
Extract logic to create Updater into DailyUpdaterFactory and some minor refactoring in DailyUpdater.cs
2024-03-14 15:43:31 +10:00
Sarah Ashri
a585b181da
Move DailyUpdate of each type to DailyUpdaterHierarchy and add a simple factory method to get the appropriate updater to use.
2024-03-14 14:27:42 +10:00
Sarah Ashri
0e52fc7c4b
Finishes separating DailyUpdate processing according to type. Still in the same method.
2024-03-13 14:28:27 +10:00
Sarah Ashri
c7eafcaeec
separate processing of different types
2024-03-13 14:12:21 +10:00
Sarah Ashri
3d28a742b5
DailyItemUpdate: extract increase/decrease quality into a separate method
2024-03-13 14:04:40 +10:00
Sarah Ashri
c85ce91a08
Add RefactoringDiary to document my refactoring journey
2024-03-13 11:55:42 +10:00
Sarah Ashri
b5f5867081
DailyItemUpdate: seperate handling for different item types
2024-03-13 11:40:26 +10:00
Sarah Ashri
03032c91c2
extracted LegendaryItems processing from if statements in DailyItemUpdate
...
LegendayItems don't change and therefore, can return immediately
2024-03-13 10:20:55 +10:00
Sarah Ashri
dd66f563e9
Extract item types condition from the DailyItemUpdate method and refactored related tests
...
* in tests:
- renamed tests to use the different item types
- Added more test cases to support the fixed functionality of better types' recognition.
* reran the 30 days texttest to verify the changes until now
2024-03-13 10:17:00 +10:00
Sarah Ashri
165322b336
Add constants for Quality min/max
2024-03-13 09:49:27 +10:00
Sarah Ashri
c657256ed9
Revert previous changes to csharp project
...
Since I'm working on csharpcore
2024-03-13 09:35:50 +10:00
Sarah Ashri
a69f02d975
ported previous refactoring to csharpcore project
...
Made the previous ones in csharp instead by mistake
2024-03-13 09:33:07 +10:00
Sarah Ashri
9fdf1140e5
Tiny rename for readability
2024-03-12 13:48:33 +10:00
Sarah Ashri
4684969140
Refactoring - extract UpdateQuality(Item) to method
2024-03-12 13:40:35 +10:00
Sarah Ashri
4f9209d154
Add full unit test coverage to existing code
...
- Without the new "Conjured" items requirements
- Tests failing due to bugs in code are ignored until after the refactoring and fix.
2024-03-12 11:57:25 +10:00
Sarah Ashri
2da08d9515
Update leftovers for the .Net Version upgrade to .Net 8.0 for csharpcore
2024-03-12 09:36:56 +10:00
Emily Bache
51ad110e95
add Patreon link
2024-03-07 15:07:10 +01:00
Peter Kofler
bda4c1c971
Merge pull request #525 from jannismain/main
...
fix deprecated usage of assertEquals
2024-03-02 10:30:59 +01:00
Jannis Mainczyk
dd50681dae
fix deprecated usage of assertEquals
...
should be assertEqual, as the other form has been deprecated since 2010 and since been removed
2024-03-01 16:42:20 +01:00
Emily Bache
2a2770b10d
Merge pull request #523 from pdmoore/patch-1
...
Update csharp.csproj
2024-02-20 07:54:04 +01:00
Paul Moore
ce64de1f2a
Update csharp.csproj
...
upgrade to .Net8.0 via Microsoft's command line upgrade-assistant.
.Net6.0 support ends in November 2024.
Other .Net/C# projects in the GildedRose repo are already at .Net8.0
2024-02-19 13:49:29 -08:00
emily
46b4caf028
update versions of dependencies but not version of Java
2024-02-13 17:01:26 +01:00
emily
5792d8d72a
ignore mac DS_Store
2024-02-13 16:53:41 +01:00
Emily Bache
209c40323c
Merge pull request #522 from danielmpetrov/refactor/csharp-core-update-framework-and-libs
...
[Refactor] .NET Core Templates - Update Framework and Libraries
2024-02-05 14:43:53 +01:00
Daniel Petrov
4adba8f57f
Formatting
2024-02-05 12:57:07 +01:00
Daniel Petrov
0230368b96
Formatting
2024-02-05 12:55:05 +01:00
Daniel Petrov
0e23a6f8ae
Formatting
2024-02-05 12:52:23 +01:00
Daniel Petrov
03a9d294d2
Update csharp core nunit project to latest SDK and libs
2024-02-05 12:37:27 +01:00
Daniel Petrov
cd4d9f6f0d
Update csharp core xunit project to the latest SDK and libs
2024-02-05 12:22:32 +01:00
Peter Kofler
e43a1a270f
Replace complete tests with sample tests.
2024-01-17 20:12:19 +01:00
Cp shivhare
92a459442a
Fixed and add rspec
2024-01-17 20:05:35 +01:00
Cp shivhare
24c9a7f603
Fixed and add minitest
2024-01-17 20:05:35 +01:00
Cp shivhare
70ca9b9569
Made runnable for ruby
2024-01-17 20:05:35 +01:00
Peter Kofler
4bfda69d39
Merge pull request #515 from bronsonmcn/ruby-fix
...
doc - update command to run ruby tests
2024-01-07 14:47:23 +01:00
Bronson McNaughton
1bbc3b408a
doc - update command to run ruby tests
2024-01-07 12:09:21 +13:00
Peter Kofler
31bef1d837
Merge pull request #514 from nitsanavni/jq-simplify
...
jq: simplify
2024-01-06 22:38:30 +01:00
Peter Kofler
39091d3b65
Merge pull request #513 from nitsanavni/bash
...
bash: simplify texttest fixture
2024-01-06 22:33:31 +01:00
Nitsan Avni
d5b430fde9
- r jq: jaq -> jq, rm foreach
2024-01-05 09:21:12 +01:00
Nitsan Avni
dc652d4d09
. t bash/texttest_fixture.sh temp file -> variable
2024-01-05 09:11:57 +01:00
Emily Bache
a1e48be19f
Merge pull request #509 from nitsanavni/bash
...
bash
2023-12-28 08:27:57 +00:00
Nitsan Avni
6223bf9919
- F more compact
2023-12-26 18:09:52 +01:00
Nitsan Avni
7658124173
gilded_rose.sh: closer to original
2023-12-26 12:27:11 +01:00
