Commit Graph

12 Commits

Author SHA1 Message Date
Maarten Parmentier
cc494bf27e Extract normal item cases
All tests pass, both rspec as texttests. This gives me a good base to start implementing Conjured items.
The idea is to implement Conjured items first before starting to clean up the code.
My thought process when implementing new code is always: make it work -> make it safe -> clean it up
2023-06-27 20:37:29 +02:00
Maarten Parmentier
14363a173b Extract Backstage Passes 2023-06-27 20:32:24 +02:00
Maarten Parmentier
3d86d3d0ef Extract 'Aged Brie'
Also noticed I made a mistake in some specs, would normally optimise spec code later on.
Added an extra test for when sell_in is 1 for safety as it depends on the order of operations in the extraction I make.
2023-06-27 20:22:05 +02:00
Maarten Parmentier
6d4bc3f8af Extract the first item case: "Sulfuras" 2023-06-27 19:47:49 +02:00
Maarten Parmentier
f0204a4b1e Write tests for all types of items
Without looking at the code I've written specs based on the requirements listed and the output of the texttest.
All specs are green except for the expected 2 failing 'quality' tests for the new 'Conjured' item.
With all models tested I feel more comfortable starting the refactor. The plan at the moment is to extract the code of 1 type of item at the time into it's own method.
2023-06-26 22:57:33 +02:00
Agata Werszler
50daf3f025 Change line separator from CRLF to LF 2020-09-25 16:45:40 +02:00
emily
3c3d60414f added ruby gitignore 2020-05-07 08:44:42 +02:00
Dani Latorre
778db32d9e should syntax is deprecated, changed the first test to expect syntax 2016-08-02 15:03:07 +02:00
Dani Latorre
4dead49ba8 nested formatter was renamed to documentation 2016-08-02 15:02:20 +02:00
Peter Kofler
75a2a15f14 format Ruby code (only whitespace changes) 2014-01-25 23:01:39 +01:00
Peter Kofler
0ff5cb7608 add Ruby Eclipse settings 2014-01-25 23:01:39 +01:00
emilybache
567c27854a Removed all the code except for the GildedRose kata from this repo 2013-06-10 14:42:41 +02:00