Sarah Ashri
d076fc9ba4
Add ItemBuilders hierarchy to enforce building valid items
...
Also updated unit tests:
- Added unit tests for the new ItemBuilders classes
- Refactored existing tests to use the new builders
2024-03-15 11:46:55 +10:00
Sarah Ashri
eb741a95c5
Seperated the derived DailyUpdater classes into their own files
2024-03-15 11:23:20 +10:00
Sarah Ashri
5e5d6e9fa7
Extract item types and quality into their own classes to allow reuse
2024-03-15 11:18:11 +10:00
Sarah Ashri
9293c86c66
DailyUpdaterFactory reuse existing updaters instead of creating new ones every time.
2024-03-15 09:03:42 +10:00
Sarah Ashri
7fbb554030
Extract logic to create Updater into DailyUpdaterFactory and some minor refactoring in DailyUpdater.cs
2024-03-14 15:43:31 +10:00
Sarah Ashri
a585b181da
Move DailyUpdate of each type to DailyUpdaterHierarchy and add a simple factory method to get the appropriate updater to use.
2024-03-14 14:27:42 +10:00
Sarah Ashri
0e52fc7c4b
Finishes separating DailyUpdate processing according to type. Still in the same method.
2024-03-13 14:28:27 +10:00
Sarah Ashri
c7eafcaeec
separate processing of different types
2024-03-13 14:12:21 +10:00
Sarah Ashri
3d28a742b5
DailyItemUpdate: extract increase/decrease quality into a separate method
2024-03-13 14:04:40 +10:00
Sarah Ashri
c85ce91a08
Add RefactoringDiary to document my refactoring journey
2024-03-13 11:55:42 +10:00
Sarah Ashri
b5f5867081
DailyItemUpdate: seperate handling for different item types
2024-03-13 11:40:26 +10:00
Sarah Ashri
03032c91c2
extracted LegendaryItems processing from if statements in DailyItemUpdate
...
LegendayItems don't change and therefore, can return immediately
2024-03-13 10:20:55 +10:00
Sarah Ashri
dd66f563e9
Extract item types condition from the DailyItemUpdate method and refactored related tests
...
* in tests:
- renamed tests to use the different item types
- Added more test cases to support the fixed functionality of better types' recognition.
* reran the 30 days texttest to verify the changes until now
2024-03-13 10:17:00 +10:00
Sarah Ashri
165322b336
Add constants for Quality min/max
2024-03-13 09:49:27 +10:00
Sarah Ashri
a69f02d975
ported previous refactoring to csharpcore project
...
Made the previous ones in csharp instead by mistake
2024-03-13 09:33:07 +10:00
Sarah Ashri
4f9209d154
Add full unit test coverage to existing code
...
- Without the new "Conjured" items requirements
- Tests failing due to bugs in code are ignored until after the refactoring and fix.
2024-03-12 11:57:25 +10:00
Sarah Ashri
2da08d9515
Update leftovers for the .Net Version upgrade to .Net 8.0 for csharpcore
2024-03-12 09:36:56 +10:00
Daniel Petrov
0230368b96
Formatting
2024-02-05 12:55:05 +01:00
Daniel Petrov
0e23a6f8ae
Formatting
2024-02-05 12:52:23 +01:00
Daniel Petrov
03a9d294d2
Update csharp core nunit project to latest SDK and libs
2024-02-05 12:37:27 +01:00
Ron Heywood
9fd97e0fcb
Tests named 30 days are run over 30 days
2023-11-28 08:46:04 +00:00
emily
e188faef86
make sure texttests work for C#
2023-11-03 16:18:25 +01:00
Stéphane Bagnier
7ebb8d2b61
csharpcore use .NET7
2023-10-28 07:03:22 +02:00
Stéphane Bagnier
ffdfe37fcd
make csharpcore work. I add a missing NuGet, use only one test framework, downgrade to NET6 LTS and var some variables.
2023-10-27 10:40:48 +02:00
Maxim Stomphorst
ad56fa1ce0
cleanup
2023-08-30 21:02:31 +02:00
emily
6a91a10bfa
update to latest .net version
2023-08-29 11:36:23 +02:00
Clare Sudbery
8d30f5efce
Remove approved.txt, for consistency with rest of repo
2023-04-10 11:40:45 +01:00
Clare Sudbery
8d0e82c2a6
Add default valid approved.txt to csharpcore
2023-04-08 14:55:45 +01:00
Clare Sudbery
588dbed420
Add approval test to csharpcore
2023-04-08 14:55:23 +01:00
Clare Sudbery
416b299856
Add Nuget packages needed for approval tests
2023-04-08 14:35:31 +01:00
Clare Sudbery
11569e0c0f
Test 31 days instead of 2
2023-04-08 14:21:07 +01:00
Samuel Dufour
4746d897f5
Remove ApprovalTest and add TexttestFixture
2021-12-27 23:25:40 +01:00
Kyle McMaster
7d795a5d67
chore(csharp-core): update packages and framework to .net 6.0
2021-12-03 22:29:48 -08:00
Will Verland
85a1611787
Fix misspelling of Guilded => Gilded for PR #252
2021-07-23 11:30:53 +12:00
Will Verland
b556848479
Add separate project for tests
2021-07-22 08:52:23 +12:00
Will Verland
3eec127eff
Add Visual Studio solution
2021-07-22 08:37:20 +12:00
Will Verland
0e0c025509
Rename C# project to GuildedRose
2021-07-22 08:37:04 +12:00
Will Verland
c87a4acc2d
Update csharpcore Nuget dependencies
...
I updated the dependencies one at a time. I ran the program and the
tests after each package was upgraded to ensure that no compiler
warnings or changes in behaviour were introduced.
2021-07-21 16:52:44 +12:00
Will Verland
80fca5097e
Upgrade csharpcore from .NET Core 2.1 to 3.1
...
.NET Core 2.1 loses support on the 21st August 2021. The current Long
Term Support version of .NET Core is 3.1. See https://docs.microsoft.com/en-us/lifecycle/products/microsoft-net-and-net-core for details.
2021-07-21 16:37:12 +12:00
Emily Bache
fbcc8aaa4d
fix approval tests to work on windows, and use Approvals framework
2019-08-28 10:30:34 +02:00
Emanuele Longo
fdc5a78efb
C# for .net core
2018-06-14 16:54:48 +02:00
