GildedRose-Refactoring-Kata

OpenSource/GildedRose-Refactoring-Kata

0 Fork 0

mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-10-15 18:43:53 +00:00

Commit Graph

Select branches

Hide Pull Requests

main

#1

#100

#101

#102

#103

#104

#105

#106

#107

#109

#11

#110

#111

#112

#113

#114

#115

#117

#118

#12

#120

#121

#122

#123

#124

#126

#127

#128

#129

#13

#130

#131

#132

#133

#134

#135

#136

#137

#138

#139

#14

#140

#141

#142

#143

#144

#145

#146

#147

#148

#149

#15

#150

#151

#152

#153

#154

#155

#156

#157

#159

#16

#160

#161

#162

#163

#164

#165

#166

#167

#168

#169

#17

#170

#171

#172

#173

#174

#176

#177

#178

#179

#18

#180

#181

#182

#183

#184

#185

#186

#187

#188

#189

#19

#190

#191

#192

#193

#194

#196

#197

#198

#199

#2

#20

#200

#201

#202

#203

#204

#205

#206

#207

#208

#209

#21

#210

#211

#212

#214

#215

#216

#217

#218

#219

#22

#22/merge

#220

#221

#222

#223

#224

#225

#226

#227

#228

#229

#23

#230

#231

#232

#233

#234

#235

#236

#237

#238

#239

#24

#24/merge

#240

#241

#242

#243

#244

#245

#246

#247

#248

#249

#25

#25/merge

#250

#251

#252

#253

#254

#255

#256

#257

#258

#259

#26

#260

#261

#262

#264

#265

#266

#267

#268

#27

#270

#271

#272

#273

#274

#275

#276

#277

#278

#279

#28

#280

#281

#282

#283

#284

#285

#286

#287

#288

#289

#29

#290

#291

#292

#293

#294

#295

#296

#297

#298

#299

#3

#30

#30/merge

#300

#301

#302

#303

#304

#305

#306

#307

#308

#309

#31

#310

#311

#313

#314

#315

#316

#317

#318

#319

#320

#321

#322

#323

#324

#325

#326

#327

#328

#329

#33

#330

#331

#332

#333

#334

#335

#336

#337

#338

#339

#340

#341

#342

#343

#344

#345

#346

#347

#348

#349

#35

#350

#351

#352

#353

#354

#355

#356

#357

#358

#36

#361

#362

#363

#364

#365

#366

#367

#368

#369

#37

#370

#371

#372

#373

#374

#375

#376

#377

#378

#379

#38

#38/merge

#380

#381

#382

#383

#384

#385

#386

#387

#388

#389

#39

#39/merge

#390

#391

#392

#393

#394

#395

#396

#397

#399

#4

#40

#400

#401

#402

#403

#404

#405

#406

#407

#409

#41

#410

#411

#412

#413

#414

#415

#416

#417

#418

#419

#42

#420

#421

#422

#423

#424

#425

#426

#427

#428

#429

#430

#431

#432

#433

#434

#435

#436

#437

#438

#439

#44

#440

#441

#442

#443

#445

#446

#447

#448

#449

#450

#451

#451/merge

#452

#453

#454

#455

#456

#457

#458

#459

#46

#460

#461

#462

#463

#464

#466

#467

#468

#469

#47

#470

#471

#473

#474

#475

#476

#477

#478

#479

#48

#480

#481

#482

#483

#484

#485

#486

#487

#488

#489

#49

#490

#491

#492

#493

#495

#496

#497

#498

#499

#5

#50

#500

#501

#502

#503

#504

#505

#506

#508

#509

#51

#510

#511

#512

#513

#514

#515

#516

#517

#518

#519

#52

#520

#521

#522

#523

#524

#525

#527

#528

#529

#53

#53/merge

#530

#531

#532

#533

#534

#535

#536

#537

#538

#539

#54

#540

#542

#543

#544

#545

#546

#547

#548

#549

#55

#550

#551

#552

#553

#554

#555

#556

#557

#558

#559

#56

#560

#562

#563

#564

#565

#566

#567

#568

#569

#57

#57/merge

#570

#571

#572

#573

#574

#575

#576

#577

#578

#58

#580

#581

#582

#583

#584

#585

#586

#587

#588

#589

#59

#590

#591

#594

#595

#596

#597

#598

#599

#6

#60

#600

#601

#602

#603

#604

#605

#606

#607

#608

#608/merge

#609

#609/merge

#61

#610

#611

#612

#613

#614

#615

#616

#617

#618

#619

#62

#620

#621

#622

#623

#624

#625

#626

#627

#628

#629

#63

#630

#631

#632

#633

#634

#635

#636

#637

#638

#639

#64

#640

#641

#642

#643

#643/merge

#645

#646

#647

#648

#649

#65

#65/merge

#650

#651

#652

#653

#654

#655

#656

#657

#658

#659

#66

#66/merge

#660

#661

#662

#663

#664

#665

#666

#667

#668

#669

#67

#67/merge

#670

#671

#672

#673

#674

#675

#676

#677

#678

#679

#68

#680

#681

#682

#683

#684

#685

#686

#687

#688

#689

#69

#690

#691

#692

#693

#694

#695

#696

#697

#698

#699

#7

#7/merge

#70

#700

#701

#702

#703

#704

#705

#706

#707

#708

#709

#71

#71/merge

#72

#72/merge

#73

#73/merge

#74

#74/merge

#75

#76

#77

#77/merge

#78

#78/merge

#79

#79/merge

#8

#80

#81

#82

#82/merge

#83

#84

#85

#85/merge

#86

#87

#88

#88/merge

#89

#9

#90

#91

#92

#92/merge

#93

#94

#95

#95/merge

#96

#97

#98

#99

16b7b46653 add missing @Override annotation to item's toString Peter Kofler 2014-04-13 13:40:22 +02:00
4891dcd3a2 Merge pull request #3 from codecop/master Emily Bache 2014-04-02 21:43:04 +02:00
86ee732b39 add Eclipse project setup for PHP project Peter Kofler 2014-04-01 20:06:59 +02:00
09355abb56 port GildedRose Java version to PHP with PHPUnit test Peter Kofler 2014-04-01 20:06:25 +02:00
370c77bb6b Merge pull request #2 from codecop/topull Emily Bache 2014-01-26 00:02:13 -08:00
f284d7597a add IDEA setup for Java code Peter Kofler 2013-12-30 17:14:11 +01:00
5c7eaabe2d delete redundant files/requirements in Javascript folder Peter Kofler 2013-10-22 21:08:59 +02:00
f185c17187 add initial test case for Javascript like all other (failing) test cases Peter Kofler 2013-10-22 21:08:34 +02:00
4cb34a7c73 format Python code (only whitespace changes) Peter Kofler 2013-10-22 20:59:22 +02:00
5920278cf3 add Java Eclipse settings Peter Kofler 2013-10-22 20:53:17 +02:00
7c817b1032 format Java code (only whitespace changes) Peter Kofler 2013-10-22 20:52:36 +02:00
75a2a15f14 format Ruby code (only whitespace changes) Peter Kofler 2013-10-22 20:51:02 +02:00
0ff5cb7608 add Ruby Eclipse settings Peter Kofler 2013-10-22 20:50:45 +02:00
448e074e2e Merge pull request #1 from LindaGulz/master Emily Bache 2014-01-14 06:44:34 -08:00
f60240f6b1 added scala translation Linda Gulz 2014-01-14 11:42:28 +01:00
567c27854a Removed all the code except for the GildedRose kata from this repo emilybache 2013-06-10 14:42:41 +02:00
b31a5436cc Merge pull request #18 from svdo/master Emily Bache 2013-05-31 23:35:50 -07:00
3903df6e64 Cleaned up (removed comments etc.) Stefan van den Oord 2013-05-31 21:26:06 +02:00
1216c9abed Ignore all project files Stefan van den Oord 2013-05-31 21:19:49 +02:00
8a92716cb1 Removed AppCode project files as well Stefan van den Oord 2013-05-31 21:17:56 +02:00
cb1dd8db19 Stripped the project to the bare minimum Stefan van den Oord 2013-05-31 21:12:46 +02:00
7b102278c1 Added Objective-C version of Tennis to README.md Stefan van den Oord 2013-05-31 20:50:36 +02:00
de7b01b93d Converted schemes to shared schemes Stefan van den Oord 2013-05-31 20:42:03 +02:00
a1af505230 Fixed compiler warnings. Stefan van den Oord 2013-05-31 20:39:28 +02:00
248c53b445 Refactored test so that parametrized part is separated better and more explicit Stefan van den Oord 2013-05-31 20:26:35 +02:00
aeb8c878d0 Converted to parametrized test; not as nice as it ought to be, but not exactly easy using OCUnit... Stefan van den Oord 2013-05-31 20:12:57 +02:00
99a5861125 Also ported TennisGame3. Furthermore pushed instance vars down to better match spirit of Java implementation Stefan van den Oord 2013-05-31 19:41:01 +02:00
ea3e95e55f Successfully implemented TennisGame2 Stefan van den Oord 2013-05-31 19:29:25 +02:00
1ec82a56eb Successfully ported TennisGame1 Stefan van den Oord 2013-05-31 19:21:32 +02:00
7e486cea64 Added player names to init method Stefan van den Oord 2013-05-31 18:43:02 +02:00
c57b33c2c9 Adding Objective-C version of Tennis; added Xcode+AppCode project, ported unit tests from Java version Stefan van den Oord 2013-05-31 18:28:43 +02:00
eddd5053ad make the refactoring kata instructions more interesting Emily Bache 2013-04-08 12:02:08 +02:00
5c53d149ff updated cyberdojo with new code for ruby and python versions Emily Bache 2013-04-08 11:42:45 +02:00
47aef6fd00 run all the tests on all the versions all the time Emily Bache 2013-04-08 11:37:43 +02:00
80cf89cef7 run all the tests on all the versions all the time Emily Bache 2013-04-08 11:34:47 +02:00
d15c470937 use interface so I can run all the tests against all versions of the code all the time Emily Bache 2013-04-08 11:24:46 +02:00
d3c89db5c9 Merge branch 'master' of github.com:emilybache/Refactoring-Katas Emily Bache 2013-04-08 10:39:31 +02:00
563a7fac06 Emily Bache 2013-04-08 10:39:16 +02:00
da19f94494 Merge pull request #16 from DevL/add_ruby_yahtzee Emily Bache 2013-04-07 11:09:03 -07:00
64b5914afa Revert undesired changes to the README. Kim Persson and Lennart Fridén 2013-04-07 13:10:20 +02:00
24d532ed94 Add Ruby version of the Yahtzee kata. Kim Persson and Lennart Fridén 2013-04-07 12:48:32 +02:00
e95f2ee409 Merge pull request #15 from ihaworth/JavaPackageReintroduction Emily Bache 2013-03-28 13:10:55 -07:00
852a851aad Merge pull request #13 from ihaworth/master Emily Bache 2013-03-27 13:09:51 -07:00
7158270109 Re-introduce the com.gildedrose package for the Java example. Java isn't able to reference classes in the default packge, so if you're refactoring and putting your refactored code in packges, you can't refer back to the original code (i.e. Item) from them. Ensure the TextTest reference is also updated to the new location of the test. Ian 2013-03-27 17:13:22 +00:00
a2edc93325 Remove the dependency on the CppUTestExt library as this doesn't seem to be built by the current CppUTest distribution. Ian 2013-03-27 14:01:42 +00:00
a224162428 Update the tests to work with the code that was changed in rev 4dab932c94 to be more like the original c# Ian 2013-03-27 10:30:17 +00:00
f95ce38b81 Update the tests to work with the code that was changed in rev 4dab932c94 to be more like the original c# Ian 2013-03-27 10:20:59 +00:00
5b90bc7d6a Make instructions even clearer emilybache 2013-03-20 09:46:57 +01:00
21cc3a3e85 Updated the read me with a justification of why I changed the starting position for this kata. emilybache 2013-03-20 09:43:14 +01:00
0319c8a5f7 I changed the starting position for the C# version to match the other translations, especially the Java version. This means I've actually done a small amount of refactoring already compared with the original form of the kata, and made it easier to get going with writing tests. It also makes it easier to do text-based approval testing with this code. emilybache 2013-03-20 09:33:53 +01:00
2092815e48 merge emilybache 2013-03-20 08:15:45 +01:00
c623ea5b23 minor text change emilybache 2013-03-20 08:14:18 +01:00
14b0195218 Merge pull request #12 from bmaland/patch-1 Emily Bache 2013-03-17 13:06:25 -07:00
0d41aa77c9 Add a .rspec file for colours and nested output Bjørn Arild Mæland 2013-03-15 08:42:03 +01:00
f6a5c4fe40 improved the description of text-based approval testing Emily Bache 2013-03-13 18:25:25 +01:00
e583b8461f added normal unittest version of ruby test Emily Bache 2013-03-13 18:21:40 +01:00
e103796367 ignore .pyc files Emily Bache 2013-03-13 18:21:27 +01:00
4dab932c94 updated these versions to more closely match the original C# Emily Bache 2013-03-13 18:20:38 +01:00
2e3386ab13 added links to cyberdojos for more languages Emily Bache 2013-03-13 18:18:50 +01:00
78f90ea9cf C# version of Gilded Rose in cyber-dojo emilybache 2013-02-08 15:31:37 +01:00
8462f38fe2 updated to newer version of C# tennis with better instructions emilybache 2013-02-08 14:32:55 +01:00
c2d3a90bc9 C# version now available in cyber-dojo emilybache 2013-02-05 08:08:45 +01:00
e2a9c5468d C sharp translation of Tennis kata emilybache 2013-02-01 15:38:54 +01:00
6654875bc0 Added information about GildedRose on cyber-dojo emilybache 2013-01-24 10:59:56 +01:00
6b269aab48 Merge branch 'master' of github.com:emilybache/Refactoring-Katas emilybache 2013-01-23 15:28:35 +01:00
1fcd221677 In Java it's best practice to use .equals for strings. Even though this is supposed to be legacy code, the use of == led to some hard to understand errors that distract from the exercise. emilybache 2013-01-23 15:28:15 +01:00
8f2e1acc3e Merge pull request #10 from marcoemrich/master Emily Bache 2013-01-07 00:44:15 -08:00
4bb9659190 added js version of Gilded Rose from git@github.com:guyroyse/gilded-rose-javascript.git Marco Emrich 2013-01-07 02:53:21 +01:00
2e7e36eda1 tweak of url, so instructions will be correct emilybache 2012-12-10 14:49:40 +01:00
7e52c0ddfe test cases and code that work in cyber-dojo emilybache 2012-12-10 14:49:20 +01:00
5c951978d7 removed these since I switched over to the cyber-dojo structure emilybache 2012-12-10 14:49:09 +01:00
b2687a855d Added the C++ version in cyberdojo emilybache 2012-12-10 14:43:11 +01:00
810ebd7d7e generate test cases for cyber-dojo emilybache 2012-12-10 14:35:53 +01:00
91630a3a34 convert tabs to spaces emilybache 2012-12-10 14:35:09 +01:00
690a14e482 improved the cyber-dojo links emilybache 2012-12-10 13:48:13 +01:00
980953d974 Added links to some cyber-dojo instances emilybache 2012-12-07 21:12:59 +01:00
8e3bd6076f converted tabs to spaces emilybache 2012-12-07 21:10:59 +01:00
afc37306a8 Merge branch 'master' of github.com:emilybache/Refactoring-Katas emilybache 2012-12-07 19:10:31 +01:00
1b30d88dbd First attempt at a ruby version of this kata emilybache 2012-12-07 19:10:05 +01:00
51f547d61b Merge pull request #9 from dvrensk/ruby-cleanup Emily Bache 2012-12-07 01:18:47 -08:00
7541689452 Style fix: ruby always uses 2-space indentation David Vrensk 2012-12-06 15:54:52 +01:00
9042bba0a2 Bug fix: the sample spec did not run David Vrensk 2012-12-06 15:53:43 +01:00
7333fc844e added encoding. Decided itertools.zip_longest was overkill, refactored to use simpler method. emilybache 2012-11-21 11:11:46 +01:00
1cf0963de5 made the test code more realistic - have each player score a point in turn instead of all at once. emilybache 2012-11-21 10:59:47 +01:00
52fb51eede Fixed an issue where the tests weren't really doing a realistic game. Now the players exchange points instead of one player scoring all theirs, and the other player scoring all theirs. emilybache 2012-11-21 10:48:38 +01:00
5fb9f52b48 added encoding, fixed som PEP-8 issues. Thanks to apieum for these changes. emilybache 2012-11-21 10:21:22 +01:00
ca6f1a5b55 change to using unittest instead of py.test since it comes with the standard library emilybache 2012-11-05 20:58:35 +01:00
041c04db18 updated README file to markdown syntax, added link to texttest mailing list emilybache 2012-10-14 11:01:20 +02:00
f416ee371a Updated the README files to markdown, improved the instructions. emilybache 2012-10-12 16:17:59 +02:00
0dde408d01 C++ version of Yahtzee Kata by Jon Jagger. Taken from http://cyber-dojo.com/?id=57FFF6CEE2 emilybache 2012-10-12 15:58:55 +02:00
b6cd227450 separate file with Gilded Rose requirements emilybache 2012-10-12 15:58:16 +02:00
406fac2681 Added test case for unittest which is in the standard library, and therefore more people have it. It's a less good test though, because it is not properly parameterized. emilybache 2012-10-09 15:51:08 +02:00
837433847e Merge branch 'master' of https://github.com/flepied/Refactoring-Katas Emily Bache 2012-08-19 19:26:07 +02:00
e48300e32e ported the C++ version in C Frederic Lepied 2012-08-17 11:31:01 +02:00
55a9d1b1bf Merge branch 'master' of github.com:emilybache/Refactoring-Katas Emily Bache 2012-08-08 14:40:14 +02:00
8e10e60244 Merge pull request #7 from Neppord/master Emily Bache 2012-06-25 09:44:56 -07:00
d041b1ea8b Changed the method to use the built in pytest.mark.parametrize Samuel Ytterbrink 2012-06-25 13:39:44 +02:00
c6e4fbd20b Fixed import error, by aliasing one off the impls. Samuel Ytterbrink 2012-06-25 13:37:12 +02:00
b3509bc087 Added a new kata - Yahtzee - by Jon Jagger Emily Bache 2012-06-14 11:33:10 +02:00
4945165df2 New Refactoring Kata - Yahtzee - by Jon Jagger Emily Bache 2012-06-14 11:30:21 +02:00

... 8 9 10 11 12 ...