mirror of
https://github.com/emilybache/GildedRose-Refactoring-Kata.git
synced 2026-02-15 06:21:29 +00:00
* in tests: - renamed tests to use the different item types - Added more test cases to support the fixed functionality of better types' recognition. * reran the 30 days texttest to verify the changes until now
250 lines
9.0 KiB
C#
250 lines
9.0 KiB
C#
using FluentAssertions;
|
|
using System.Collections.Generic;
|
|
using GildedRoseKata;
|
|
using NUnit.Framework;
|
|
|
|
namespace GildedRoseTests;
|
|
|
|
public class UpdateQualityTestFixture
|
|
{
|
|
|
|
[Test]
|
|
public void PlainItems_WhenNotExpired_Should_DecreaseSellInAndQualityByOne()
|
|
{
|
|
var items = new List<Item> { new() { Name = "item 1", SellIn = 2, Quality = 3 } };
|
|
var expectedItemsAfterTest = new List<Item> { new() { Name = "item 1", SellIn = 1, Quality = 2 } };
|
|
|
|
var app = new GildedRose(items);
|
|
app.UpdateQuality();
|
|
|
|
items.Should().BeEquivalentTo(expectedItemsAfterTest);
|
|
}
|
|
|
|
|
|
[Test]
|
|
public void PlainItems_WhenExpired_Should_DecreaseSellInByOneAndQualityByTwo()
|
|
{
|
|
var items = new List<Item> { new() { Name = "item 1", SellIn = 0, Quality = 5 } };
|
|
var expectedItemsAfterDay1 = new List<Item> { new() { Name = "item 1", SellIn = -1, Quality = 3 } };
|
|
var expectedItemsAfterDay2 = new List<Item> { new() { Name = "item 1", SellIn = -2, Quality = 1 } };
|
|
|
|
|
|
var app = new GildedRose(items);
|
|
|
|
app.UpdateQuality();
|
|
items.Should().BeEquivalentTo(expectedItemsAfterDay1);
|
|
|
|
app.UpdateQuality();
|
|
items.Should().BeEquivalentTo(expectedItemsAfterDay2);
|
|
}
|
|
|
|
[Test]
|
|
public void ItemsQuality_Should_NeverGoBelow0()
|
|
{
|
|
var items = new List<Item>
|
|
{
|
|
new() { Name = "item 1", SellIn = 0, Quality = 0 },
|
|
new() { Name = "item 1", SellIn = 0, Quality = 1 }
|
|
};
|
|
var expectedItemsAfterTest = new List<Item>
|
|
{
|
|
new() { Name = "item 1", SellIn = -1, Quality = 0 },
|
|
new() { Name = "item 1", SellIn = -1, Quality = 0 }
|
|
};
|
|
|
|
|
|
var app = new GildedRose(items);
|
|
app.UpdateQuality();
|
|
|
|
items.Should().BeEquivalentTo(expectedItemsAfterTest);
|
|
}
|
|
|
|
|
|
[Test]
|
|
public void BetterWithAgeItems_WhenNotExpired_Should_IncreaseQualityByOne()
|
|
{
|
|
var items = new List<Item> { new() { Name = "Aged Brie", SellIn = 1, Quality = 0 } };
|
|
var expectedItemsAfterTest = new List<Item> { new() { Name = "Aged Brie", SellIn = 0, Quality = 1 } };
|
|
|
|
var app = new GildedRose(items);
|
|
app.UpdateQuality();
|
|
|
|
items.Should().BeEquivalentTo(expectedItemsAfterTest);
|
|
}
|
|
|
|
[Test]
|
|
public void BetterWithAgeItems_WhenExpired_Should_IncreaseQualityByTwo()
|
|
{
|
|
var items = new List<Item> { new() { Name = "aged Brie", SellIn = 0, Quality = 1 } };
|
|
var expectedItemsAfterTest = new List<Item> { new() { Name = "aged Brie", SellIn = -1, Quality = 3 } };
|
|
|
|
var app = new GildedRose(items);
|
|
app.UpdateQuality();
|
|
|
|
items.Should().BeEquivalentTo(expectedItemsAfterTest);
|
|
}
|
|
|
|
|
|
[Test]
|
|
public void ItemsQuality_Should_NeverIncreaseAbove50()
|
|
{
|
|
var items = new List<Item> { new() { Name = "Aged Brie", SellIn = 1, Quality = 49 } };
|
|
var expectedItemsAfterDay1 = new List<Item> { new() { Name = "Aged Brie", SellIn = 0, Quality = 50 } };
|
|
var expectedItemsAfterDay2 = new List<Item> { new() { Name = "Aged Brie", SellIn = -1, Quality = 50 } };
|
|
|
|
var app = new GildedRose(items);
|
|
|
|
app.UpdateQuality();
|
|
items.Should().BeEquivalentTo(expectedItemsAfterDay1);
|
|
|
|
app.UpdateQuality();
|
|
items.Should().BeEquivalentTo(expectedItemsAfterDay2);
|
|
}
|
|
|
|
|
|
[Test]
|
|
public void LegendaryItems_QualityAndSellIn_NeverChange()
|
|
{
|
|
var items = new List<Item>
|
|
{
|
|
new() { Name = "Sulfuras, Hand of Ragnaros", SellIn = 3, Quality = 3 },
|
|
new() { Name = "sulfuras", SellIn = 3, Quality = 31 }
|
|
};
|
|
var expectedItemsAfterTest = new List<Item>
|
|
{
|
|
new() { Name = "Sulfuras, Hand of Ragnaros", SellIn = 3, Quality = 3 },
|
|
new() { Name = "sulfuras", SellIn = 3, Quality = 31 }
|
|
};
|
|
|
|
var app = new GildedRose(items);
|
|
|
|
app.UpdateQuality();
|
|
items.Should().BeEquivalentTo(expectedItemsAfterTest);
|
|
}
|
|
|
|
[Test]
|
|
[Ignore("not implemented yet - Legendary Items should not take quality (constant at 80)")]
|
|
public void LegendaryItems_Quality_IsConstant80()
|
|
{
|
|
var items = new List<Item> { new() { Name = "something sulfuras something", SellIn = 3 } };
|
|
var expectedItemsAfterTest = new List<Item> { new() { Name = "something sulfuras something", SellIn = 3, Quality = 80 } };
|
|
|
|
var app = new GildedRose(items);
|
|
|
|
app.UpdateQuality();
|
|
items.Should().BeEquivalentTo(expectedItemsAfterTest);
|
|
}
|
|
|
|
|
|
[Test]
|
|
public void BackstagePassesItems_WhenExpiryInOver10Days_QualityIncreaseByOne()
|
|
{
|
|
var items = new List<Item>
|
|
{
|
|
new() { Name = "Backstage passes to a TAFKAL80ETC concert", SellIn = 11, Quality = 4 },
|
|
new() { Name = "backstage passes to some other show", SellIn = 20, Quality = 40 }
|
|
};
|
|
var expectedItemsAfterTest = new List<Item>
|
|
{
|
|
new() { Name = "Backstage passes to a TAFKAL80ETC concert", SellIn = 10, Quality = 5 },
|
|
new() { Name = "backstage passes to some other show", SellIn = 19, Quality = 41 }
|
|
};
|
|
|
|
var app = new GildedRose(items);
|
|
|
|
app.UpdateQuality();
|
|
items.Should().BeEquivalentTo(expectedItemsAfterTest);
|
|
}
|
|
|
|
|
|
[Test]
|
|
public void BackstagePassesItems_WhenExpiryIn10To6Days_QualityIncreaseByTwo()
|
|
{
|
|
var items = new List<Item>
|
|
{
|
|
new() { Name = "backstage passes to a TAFKAL80ETC concert", SellIn = 10, Quality = 4 },
|
|
new() { Name = "Backstage passes to some other show", SellIn = 6, Quality = 41 }
|
|
};
|
|
var expectedItemsAfterTest = new List<Item>
|
|
{
|
|
new() { Name = "backstage passes to a TAFKAL80ETC concert", SellIn = 9, Quality = 6 },
|
|
new() { Name = "Backstage passes to some other show", SellIn = 5, Quality = 43 }
|
|
};
|
|
|
|
var app = new GildedRose(items);
|
|
|
|
app.UpdateQuality();
|
|
items.Should().BeEquivalentTo(expectedItemsAfterTest);
|
|
}
|
|
|
|
[Test]
|
|
public void BackstagePassesItems_WhenExpiryIn5to1Days_QualityIncreaseByThree()
|
|
{
|
|
var items = new List<Item>
|
|
{
|
|
new() { Name = "Backstage passes to some other show", SellIn = 5, Quality = 4 },
|
|
new() { Name = "Backstage passes to a TAFKAL80ETC concert", SellIn = 1, Quality = 41 }
|
|
};
|
|
var expectedItemsAfterTest = new List<Item>
|
|
{
|
|
new() { Name = "Backstage passes to some other show", SellIn = 4, Quality = 7 },
|
|
new() { Name = "Backstage passes to a TAFKAL80ETC concert", SellIn = 0, Quality = 44 }
|
|
};
|
|
|
|
var app = new GildedRose(items);
|
|
|
|
app.UpdateQuality();
|
|
items.Should().BeEquivalentTo(expectedItemsAfterTest);
|
|
}
|
|
|
|
[Test]
|
|
public void BackstagePassesItems_MaximumQuality_Is50()
|
|
{
|
|
var items = new List<Item>
|
|
{
|
|
new() { Name = "Backstage passes", SellIn = 15, Quality = 49 },
|
|
new() { Name = "Backstage passes to some other show", SellIn = 10, Quality = 49 },
|
|
new() { Name = "Backstage passes to a TAFKAL80ETC concert", SellIn = 5, Quality = 48 }
|
|
};
|
|
var expectedItemsAfterDay1 = new List<Item>
|
|
{
|
|
new() { Name = "Backstage passes", SellIn = 14, Quality = 50 },
|
|
new() { Name = "Backstage passes to some other show", SellIn = 9, Quality = 50 },
|
|
new() { Name = "Backstage passes to a TAFKAL80ETC concert", SellIn = 4, Quality = 50 }
|
|
};
|
|
var expectedItemsAfterDay2 = new List<Item>
|
|
{
|
|
new() { Name = "Backstage passes", SellIn = 13, Quality = 50 },
|
|
new() { Name = "Backstage passes to some other show", SellIn = 8, Quality = 50 },
|
|
new() { Name = "Backstage passes to a TAFKAL80ETC concert", SellIn = 3, Quality = 50 }
|
|
};
|
|
|
|
var app = new GildedRose(items);
|
|
|
|
app.UpdateQuality();
|
|
items.Should().BeEquivalentTo(expectedItemsAfterDay1);
|
|
|
|
app.UpdateQuality();
|
|
items.Should().BeEquivalentTo(expectedItemsAfterDay2);
|
|
}
|
|
|
|
[Test]
|
|
public void BackstagePassesItems_WhenExpired_QualityDropsTo0()
|
|
{
|
|
var items = new List<Item>
|
|
{
|
|
new() { Name = "Backstage passes to a TAFKAL80ETC concert", SellIn = 0, Quality = 4 },
|
|
new() { Name = "Another type of backstage passes", SellIn = 0, Quality = 4 }
|
|
};
|
|
var expectedItemsAfterTest = new List<Item>
|
|
{
|
|
new() { Name = "Backstage passes to a TAFKAL80ETC concert", SellIn = -1, Quality = 0 },
|
|
new() { Name = "Another type of backstage passes", SellIn = -1, Quality = 0 }
|
|
};
|
|
|
|
var app = new GildedRose(items);
|
|
|
|
app.UpdateQuality();
|
|
items.Should().BeEquivalentTo(expectedItemsAfterTest);
|
|
}
|
|
} |