OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-19 08:21:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
9202855a5d
GildedRose-Refactoring-Kata/csharp
History
Emmanuel 9202855a5d . 
.
2021-04-27 23:54:10 +02:00
..
Properties Added files needed to run the csharp project on VS15/17 2017-09-01 00:00:42 -03:00
.gitignore Added .gitignore file 2017-08-31 23:58:11 -03:00
App.config Added files needed to run the csharp project on VS15/17 2017-09-01 00:00:42 -03:00
ApprovalTest.cs Unit Tests 2021-04-27 11:15:31 +02:00
ApprovalTest.ThirtyDays.received.txt Unit Tests 2021-04-27 11:15:31 +02:00
csharp.csproj fix approval tests to work on windows, and use Approvals framework 2019-08-28 10:30:34 +02:00
csharp.sln Unit Tests 2021-04-27 11:15:31 +02:00
GildedRose.cs . 2021-04-27 23:54:10 +02:00
GildedRoseTest.cs Unit Tests 2021-04-27 11:15:31 +02:00
Item.cs remove ApprovalTest since the other languages don't have one 2018-08-10 14:43:38 +02:00
packages.config Updated NUnit to 3.9 2017-11-19 12:12:04 +01:00
Program.cs . 2021-04-27 23:54:10 +02:00
README.md Unit Tests 2021-04-27 11:15:31 +02:00

README.md

Gilded Rose Refactoring Kata

Introduction: I will try as much as I can to write my thought processes here as it's one of the requirements. I will just write the relevant parts and not my whole thoughts. That would be weird since I was thinking of lunch just before I started. :D

SIDE COMMENTS:

  • I couldn't exactly do a full TDD since the application is already written. TDD requires tests before development but this is a refactoring.
  • One of the things I would ideally change if it was not explicitly said to not to is the fact that it uses strings to check. that can be really erroneous. If I had my way, I would include IDs of some sort.

1: One of the first things I want to do is just get the program to run. so am not fixing anything except what will make the program run.

  • The program seems to run fine. except I could not see the results so added a little line to see what was printed. over than that. it looks good. Makes sense why they kept using it. It works! :/

2: After this I want to include some Unit tests to ensure all parts are working as they should. This may require some fixing. Not sure.

  • First thing I did was separate the tests from the main application. I do not want to have the possibility of a memory leak or bulky apps
  • Original unit tests were written in NUnit and I chose to use MSTest. Why? no reason! Just a choice.

3: Then when all tests are good. I can start working with an aim of not breaking any tests.