OpenSource/PVE-mods
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

move debug save path and filename to global variables, add check if save path exists, other review comments.

Browse Source
This commit is contained in:
Meliox 2024-06-15 22:34:21 +02:00
parent b29000850e
commit 9e8b1bcd12
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
pve-mod-gui-sensors.sh
View File

@ -26,6 +26,10 @@ BACKUP_DIR="$SCRIPT_CWD/backup"
pvemanagerlibjs="/usr/share/pve-manager/js/pvemanagerlib.js" pvemanagerlibjs="/usr/share/pve-manager/js/pvemanagerlib.js"
nodespm="/usr/share/perl5/PVE/API2/Nodes.pm" nodespm="/usr/share/perl5/PVE/API2/Nodes.pm"
# Debug location
DEBUG_SAVE_PATH="$SCRIPT_CWD"
DEBUG_SAVE_FILENAME="sensorsdata.json"
############################################### ###############################################
# Helper functions # Helper functions
@ -769,16 +773,20 @@ function restart_proxy {
} }
function save_sensors_data { function save_sensors_data {
local script_dir filepath # Check if DEBUG_SAVE_PATH exists and is writable
# Check if [[ ! -d "$DEBUG_SAVE_PATH" || ! -w "$DEBUG_SAVE_PATH" ]]; then
err "Directory $DEBUG_SAVE_PATH does not exist or is not writable. No file could be saved"
return
fi
# Check if command exists
if (command -v sensors &>/dev/null); then if (command -v sensors &>/dev/null); then
# Save sensors output to sensorsdata.json in the script directory # Save sensors output
script_dir="$(dirname "$0")" local filepath="$DEBUG_SAVE_PATH/$DEBUG_SAVE_FILENAME"
filepath="$script_dir/sensorsdata.json"
sensors -j > "$filepath" sensors -j > "$filepath"
msgb "Sensors data saved in $filepath" msgb "Sensors data saved in $filepath"
else else
err "Sensors in not installed. No file could be saved" err "Sensors is not installed. No file could be saved"
fi fi
} }
@ -801,7 +809,7 @@ while [[ $# -gt 0 ]]; do
;; ;;
save-sensors-data) save-sensors-data)
executed=$(($executed + 1)) executed=$(($executed + 1))
msgb "\nSaves the Sensors json output into a file that can be used for debugging..." msgb "\nSaving current sensor readings in a file for debugging..."
save_sensors_data save_sensors_data
echo # add a new line echo # add a new line
;; ;;