OpenSource/PVE-mods
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(node_info): normalize UPS data — derive ups.realpower fallback and clean invalid battery.mfr.date (#309)

Browse Source 
Co-authored-by: Meliox <na>
This commit is contained in:
Meliox 2026-08-22 23:17:59 +02:00 committed by GitHub
parent c768eac6e3
commit bdb3f9f3df
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 29 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/modules/node_info/files/Collector/Ups.pm
View File

@ -112,6 +112,8 @@ sub _parse_upsc_output {
}
}
}
_normalize_ups_data($ups_data);
};
if ($@) {
debug(__LINE__, "Error parsing upsc output: $@");
@ -122,4 +124,28 @@ sub _parse_upsc_output {
return $ups_data;
}
# ============================================================================
# UPS — data normalization
# ============================================================================
sub _normalize_ups_data {
my ($ups_data) = @_;
# Some devices report a placeholder (e.g. "OPEN") instead of a real date
if (defined $ups_data->{'battery.mfr.date'} && $ups_data->{'battery.mfr.date'} !~ m{^\d{4}[/-]\d{1,2}[/-]\d{1,2}$}) {
delete $ups_data->{'battery.mfr.date'};
}
# Derive real power draw for devices that don't report ups.realpower directly
if (!defined $ups_data->{'ups.realpower'}) {
if (defined $ups_data->{'ups.load'} && defined $ups_data->{'ups.realpower.nominal'}) {
$ups_data->{'ups.realpower'} = int((($ups_data->{'ups.load'} / 100) * $ups_data->{'ups.realpower.nominal'}) + 0.5);
} elsif (defined $ups_data->{'output.current'} && defined $ups_data->{'output.voltage'}) {
$ups_data->{'ups.realpower'} = int(($ups_data->{'output.current'} * $ups_data->{'output.voltage'}) + 0.5);
}
}
return;
}
1;

10
src/modules/node_info/files/PveMod_pvemanagerlib.js
View File

@ -976,7 +976,7 @@ Ext.define('PVE.node.StatusView', {
const testResult = upsData['ups.test.result'];
const batteryChargeLow = upsData['battery.charge.low'];
const batteryRuntimeLow = upsData['battery.runtime.low'];
const upsRealPowerNominal = upsData['ups.realpower.nominal'];
const upsRealPower = upsData['ups.realpower'];
const batteryMfrDate = upsData['battery.mfr.date'];
// Main status line with all metrics
@ -1053,12 +1053,8 @@ Ext.define('PVE.node.StatusView', {
// Calculate actual watt usage
if (statusLine) statusLine += ' | ';
let actualWattage = null;
if (upsLoad && upsRealPowerNominal) {
const load = parseFloat(upsLoad);
const nominal = parseFloat(upsRealPowerNominal);
if (!isNaN(load) && !isNaN(nominal)) {
actualWattage = Math.round((load / 100) * nominal);
}
if (upsRealPower && !isNaN(parseFloat(upsRealPower))) {
actualWattage = Math.round(parseFloat(upsRealPower));
}
// Real power (calculated watt usage)